Linux-Fsdevel Archive on lore.kernel.org
 help / Atom feed
From: Mike Marshall <hubcap@omnibond.com>
To: Christoph Hellwig <hch@lst.de>
Cc: hubcap@kernel.org, linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	Al Viro <viro@zeniv.linux.org.uk>, Jens Axboe <axboe@kernel.dk>,
	Martin Brandenburg <martin@omnibond.com>
Subject: Re: [PATCH 1/2] orangefs: remove two un-needed BUG_ONs...
Date: Wed, 6 Feb 2019 08:22:58 -0500
Message-ID: <CAOg9mSRNGDpHhrJLTO7pr9tbQd_3Z+phE+utm4sTigcU=+S5gQ@mail.gmail.com> (raw)
In-Reply-To: <20190206065828.GB23392@lst.de>

Yes, but I don't think they should be there. You put them into
pvfs2_file_aio_read_iovec way back when (Martin guesses you
were making sure that you had fully eradicated private's use)
and I left them in when I changed that function over to
pvfs2_file_read_iter. After that, they've just gone along for
the ride... BUG_ONs that the maintainer can't justify
might be the kind of thing that would make Linus violate
the new code of conduct :-) ...

-Mike

On Wed, Feb 6, 2019 at 1:58 AM Christoph Hellwig <hch@lst.de> wrote:
>
> Didn't these catch the issue you fix in patch 2?

  reply index

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-05 19:13 [PATCH 0/2] aio: intialize kiocb private hubcap
2019-02-05 19:13 ` [PATCH 1/2] orangefs: remove two un-needed BUG_ONs hubcap
2019-02-06  6:58   ` Christoph Hellwig
2019-02-06 13:22     ` Mike Marshall [this message]
2019-02-05 19:13 ` [PATCH 2/2] aio: initialize kiocb private in case any filesystems expect it hubcap
2019-02-06  6:58   ` Christoph Hellwig
2019-02-06 15:05 ` [PATCH 0/2] aio: intialize kiocb private Jens Axboe

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOg9mSRNGDpHhrJLTO7pr9tbQd_3Z+phE+utm4sTigcU=+S5gQ@mail.gmail.com' \
    --to=hubcap@omnibond.com \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=hubcap@kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=martin@omnibond.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Fsdevel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-fsdevel/0 linux-fsdevel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-fsdevel linux-fsdevel/ https://lore.kernel.org/linux-fsdevel \
		linux-fsdevel@vger.kernel.org linux-fsdevel@archiver.kernel.org
	public-inbox-index linux-fsdevel


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-fsdevel


AGPL code for this site: git clone https://public-inbox.org/ public-inbox