From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B059C169C4 for ; Wed, 6 Feb 2019 13:23:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4D10620844 for ; Wed, 6 Feb 2019 13:23:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=omnibond-com.20150623.gappssmtp.com header.i=@omnibond-com.20150623.gappssmtp.com header.b="hejzFRSf" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730649AbfBFNXM (ORCPT ); Wed, 6 Feb 2019 08:23:12 -0500 Received: from mail-yw1-f68.google.com ([209.85.161.68]:46765 "EHLO mail-yw1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729625AbfBFNXL (ORCPT ); Wed, 6 Feb 2019 08:23:11 -0500 Received: by mail-yw1-f68.google.com with SMTP id n12so3058499ywn.13 for ; Wed, 06 Feb 2019 05:23:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=omnibond-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8bri9ss1P5Ayxx9hFHGrPcFQz4e4l8BXxFvv/SblOp4=; b=hejzFRSfvwqaFZQROqPY9BPZ5APBKbbO2Cdchxqxr6K6JjxJNYhuRvKclZLe/zgUdg 5ZHcvGUTto2tSJ2HZ5tTz4qlNF4BLzMJvA48T+dqY7hrbtdcwx7UyVNj5v8kFP8ttDNO A+9CDDw1mv7xsRfsaTtCdIC3/Nb1GnxViOBFinpwAFh6p0sru+hua+gdRx05pdH1spg0 mk/xKTr3873k1VDhunFGR4HZdyeHU9y4gN/rnJVd5+ovQWF3OypXCzf9FzwDLS1bkk6l N0hTqG6zJiJgKnxbOE6Mn4UiOkRMTac73S7XqUcaDTMmHoYivdFMAohFUJAo1OaOV5+U MWfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8bri9ss1P5Ayxx9hFHGrPcFQz4e4l8BXxFvv/SblOp4=; b=G1gfzf3xFid4bEf3eCLbh4BEAxjNuQa+VJXEJaRMVo49LGoeInOJSVNxIKqmVZ6yhY RnI3iFSDV7rDcV+WbUwZ4QQkMZx4jPSFyfDur6PPkzmS9GZLwJQo4eOLi2bOIjS/LpQ3 wtSnANwPsSxkhs+Y5bZvd+sWEFnLJFIG2N//36mP+FxJkDsqvl7cT8vx9him7l5NfN+b fCKtvNdkES5MC56eELVcnbkrtYMk76boB2NMQOn1DOLn+FAQ1wSG0XUbbBeI8nwcXbnz Qn7mAaJSGMUFbPy9pJV2/gVk3roJtlqO6/kd8sm/Z0IEcg+QA3f+/+kjK6j/28bpMWwd WZSQ== X-Gm-Message-State: AHQUAuaN/UxZKxRY13fLBDAHYNTrN8Z2jkTloM8b3QLyB/fUvLLKKt6e XjBW5ZUdxYy8TO7UIlX9bt6HowRgY4C/Oo4CQYS+xQ== X-Google-Smtp-Source: AHgI3IbPgryL1Efang/oTntUO+engBIOZn847dWDADDTQdrJkcNwV0JVGmz7esAek8SQJF+V9GgmiHQrUgTcPfREUA0= X-Received: by 2002:a0d:f642:: with SMTP id g63mr8523724ywf.412.1549459389862; Wed, 06 Feb 2019 05:23:09 -0800 (PST) MIME-Version: 1.0 References: <20190205191335.22056-1-hubcap@kernel.org> <20190205191335.22056-2-hubcap@kernel.org> <20190206065828.GB23392@lst.de> In-Reply-To: <20190206065828.GB23392@lst.de> From: Mike Marshall Date: Wed, 6 Feb 2019 08:22:58 -0500 Message-ID: Subject: Re: [PATCH 1/2] orangefs: remove two un-needed BUG_ONs... To: Christoph Hellwig Cc: hubcap@kernel.org, linux-fsdevel , Al Viro , Jens Axboe , Martin Brandenburg Content-Type: text/plain; charset="UTF-8" Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Yes, but I don't think they should be there. You put them into pvfs2_file_aio_read_iovec way back when (Martin guesses you were making sure that you had fully eradicated private's use) and I left them in when I changed that function over to pvfs2_file_read_iter. After that, they've just gone along for the ride... BUG_ONs that the maintainer can't justify might be the kind of thing that would make Linus violate the new code of conduct :-) ... -Mike On Wed, Feb 6, 2019 at 1:58 AM Christoph Hellwig wrote: > > Didn't these catch the issue you fix in patch 2?