From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk0-f48.google.com ([209.85.213.48]:34471 "EHLO mail-vk0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756694AbcKKSHA (ORCPT ); Fri, 11 Nov 2016 13:07:00 -0500 MIME-Version: 1.0 In-Reply-To: References: <20161111060515.GQ19539@ZenIV.linux.org.uk> From: Ilya Dryomov Date: Fri, 11 Nov 2016 19:06:59 +0100 Message-ID: Subject: Re: [git pull] vfs.git To: Linus Torvalds Cc: Al Viro , Yan Zheng , Linux Kernel Mailing List , linux-fsdevel Content-Type: text/plain; charset=UTF-8 Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, Nov 11, 2016 at 6:25 PM, Linus Torvalds wrote: > On Thu, Nov 10, 2016 at 10:05 PM, Al Viro wrote: >> Christoph's and Jan's aio fixes, fixup for generic_file_splice_read >> (removal of pointless detritus that actually breaks it when used for gfs2 >> ->splice_read()) and fixup for generic_file_read_iter() interaction with >> ITER_PIPE destinations. > > Hmm. I also just pulled the Ceph update that has commit 8a8d56176635 > ("ceph: use default file splice read callback"). I _think_ this splice > fix makes that ceph change unnecessary. But testing is always good. > > Ilya? Can you double-check the current -git tree (well, what I *will* > push out soon after it has passed my build tests)? > > Because I think Ceph can go back to using generic_file_splice_read again. Separate to Al's splice changes in this window, there is an old issue where ceph manipulates page cache pages without the "buffer" capability from the metadata server. Zheng is working on a fix and it's all tied up together, so I'm not sure... I'm afraid he called it a week already, but we will definitely look into it. Thanks, Ilya