From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9E5AC04E87 for ; Wed, 15 May 2019 21:07:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6BF952070D for ; Wed, 15 May 2019 21:07:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="JldDYW+L" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726918AbfEOVHh (ORCPT ); Wed, 15 May 2019 17:07:37 -0400 Received: from mail-ot1-f65.google.com ([209.85.210.65]:33593 "EHLO mail-ot1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726610AbfEOVHg (ORCPT ); Wed, 15 May 2019 17:07:36 -0400 Received: by mail-ot1-f65.google.com with SMTP id 66so1438094otq.0 for ; Wed, 15 May 2019 14:07:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=zEAiaEFTDEo5AHTXNi1igG//m3yl73MYATUt/TyQM/s=; b=JldDYW+LTAR5BoMmvzt3GhFBKSNFCQljO95A7CQF8h7lezT59wkCmoZR8HlZNeo3ZX ACz18is11PqZLJkpbZTbPrVApVsXuwCwQzpumDKhMYUGYyeEKSs4shc89Funjj7rmnrR zPCblVOMVW4B/FdfDdDBm0eQtlDpcEoDreFJYHB2TrhXh9porw+VCF0gkgtOPIdPF4AY hPK/m0cAXNVhKubNUJt+B+Ge41ks183CJ7yggGXayFgFqQhy+nfr59BSRoNiAIUor77P UmqXqpMAHdjAUWsPGhNLbi9iUpZ9FsKZwds3Nd3zmasJxQ+15Rm38l4yGAgNrmpf7grH OFBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=zEAiaEFTDEo5AHTXNi1igG//m3yl73MYATUt/TyQM/s=; b=DM5kNznHLnPHVLD5Qh9ubukejEeoKuKzDRubnCEbdmPJQJRpL5lAXoNmy/Ml1KbU6f 1HP7L3QsFpjDNiJWoNVtm/s4FhitOHWVvWlmTAV2j3/UH653WhkX2k88r3quTO4lCRX4 A41V6Gyt4M4GbH5uPK7Z8r4jU9PD9sf8A4i4lCLtT11pXWR1hCYQ1GsfrSL/ed9wklb5 Ke/M9b2QWIpHcNl9rLYeo3cJ4J9dqV6I8BwLEKQi1QF3UUNwvAdeVvAYu8VFManOfMEX M4OY+Tep7hwwTEVqyWZiOh/swAIYbKzvv2+6yYzLyy2WLUHdx0B6mRmqe2sf70973/Lt tQZw== X-Gm-Message-State: APjAAAWMXUXrs13ZNL6vroqky8sBtrnw4+TPybHKAyUeESMVaVqaALJl 8LTfJmpLsN79bsoHJW/REIaUnZXPdJfeGfbIijsa6A== X-Google-Smtp-Source: APXvYqyDA/EWUSXzmLh3QyRTwliJkHZQ726n1NRYV2Be3duzD6pV8jVLvRmpMo63mBrfvCQmmCONZIUwdUcOhHdo8aI= X-Received: by 2002:a05:6830:14d3:: with SMTP id t19mr27993804otq.57.1557954454945; Wed, 15 May 2019 14:07:34 -0700 (PDT) MIME-Version: 1.0 References: <20190514145422.16923-1-pagupta@redhat.com> <20190514145422.16923-2-pagupta@redhat.com> In-Reply-To: <20190514145422.16923-2-pagupta@redhat.com> From: Dan Williams Date: Wed, 15 May 2019 14:07:23 -0700 Message-ID: Subject: Re: [PATCH v9 1/7] libnvdimm: nd_region flush callback support To: Pankaj Gupta Cc: linux-nvdimm , Linux Kernel Mailing List , virtualization@lists.linux-foundation.org, KVM list , linux-fsdevel , Linux ACPI , Qemu Developers , linux-ext4 , linux-xfs , Ross Zwisler , Vishal L Verma , Dave Jiang , "Michael S. Tsirkin" , Jason Wang , Matthew Wilcox , "Rafael J. Wysocki" , Christoph Hellwig , Len Brown , Jan Kara , "Theodore Ts'o" , Andreas Dilger , "Darrick J. Wong" , lcapitulino@redhat.com, Kevin Wolf , Igor Mammedov , jmoyer , Nitesh Narayan Lal , Rik van Riel , Stefan Hajnoczi , Andrea Arcangeli , David Hildenbrand , david , cohuck@redhat.com, Xiao Guangrong , Paolo Bonzini , Adam Borowski , yuval shaia , jstaron@google.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Tue, May 14, 2019 at 7:55 AM Pankaj Gupta wrote: > > This patch adds functionality to perform flush from guest > to host over VIRTIO. We are registering a callback based > on 'nd_region' type. virtio_pmem driver requires this special > flush function. For rest of the region types we are registering > existing flush function. Report error returned by host fsync > failure to userspace. > > Signed-off-by: Pankaj Gupta > --- > drivers/acpi/nfit/core.c | 4 ++-- > drivers/nvdimm/claim.c | 6 ++++-- > drivers/nvdimm/nd.h | 1 + > drivers/nvdimm/pmem.c | 13 ++++++++----- > drivers/nvdimm/region_devs.c | 26 ++++++++++++++++++++++++-- > include/linux/libnvdimm.h | 8 +++++++- > 6 files changed, 46 insertions(+), 12 deletions(-) > > diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c > index 5a389a4f4f65..08dde76cf459 100644 > --- a/drivers/acpi/nfit/core.c > +++ b/drivers/acpi/nfit/core.c > @@ -2434,7 +2434,7 @@ static void write_blk_ctl(struct nfit_blk *nfit_blk= , unsigned int bw, > offset =3D to_interleave_offset(offset, mmio); > > writeq(cmd, mmio->addr.base + offset); > - nvdimm_flush(nfit_blk->nd_region); > + nvdimm_flush(nfit_blk->nd_region, NULL); > > if (nfit_blk->dimm_flags & NFIT_BLK_DCR_LATCH) > readq(mmio->addr.base + offset); > @@ -2483,7 +2483,7 @@ static int acpi_nfit_blk_single_io(struct nfit_blk = *nfit_blk, > } > > if (rw) > - nvdimm_flush(nfit_blk->nd_region); > + nvdimm_flush(nfit_blk->nd_region, NULL); > > rc =3D read_blk_stat(nfit_blk, lane) ? -EIO : 0; > return rc; > diff --git a/drivers/nvdimm/claim.c b/drivers/nvdimm/claim.c > index fb667bf469c7..13510bae1e6f 100644 > --- a/drivers/nvdimm/claim.c > +++ b/drivers/nvdimm/claim.c > @@ -263,7 +263,7 @@ static int nsio_rw_bytes(struct nd_namespace_common *= ndns, > struct nd_namespace_io *nsio =3D to_nd_namespace_io(&ndns->dev); > unsigned int sz_align =3D ALIGN(size + (offset & (512 - 1)), 512)= ; > sector_t sector =3D offset >> 9; > - int rc =3D 0; > + int rc =3D 0, ret =3D 0; > > if (unlikely(!size)) > return 0; > @@ -301,7 +301,9 @@ static int nsio_rw_bytes(struct nd_namespace_common *= ndns, > } > > memcpy_flushcache(nsio->addr + offset, buf, size); > - nvdimm_flush(to_nd_region(ndns->dev.parent)); > + ret =3D nvdimm_flush(to_nd_region(ndns->dev.parent), NULL); > + if (ret) > + rc =3D ret; > > return rc; > } > diff --git a/drivers/nvdimm/nd.h b/drivers/nvdimm/nd.h > index a5ac3b240293..0c74d2428bd7 100644 > --- a/drivers/nvdimm/nd.h > +++ b/drivers/nvdimm/nd.h > @@ -159,6 +159,7 @@ struct nd_region { > struct badblocks bb; > struct nd_interleave_set *nd_set; > struct nd_percpu_lane __percpu *lane; > + int (*flush)(struct nd_region *nd_region, struct bio *bio); So this triggers: In file included from drivers/nvdimm/e820.c:7: ./include/linux/libnvdimm.h:140:51: warning: =E2=80=98struct bio=E2=80=99 d= eclared inside parameter list will not be visible outside of this definition or declaration int (*flush)(struct nd_region *nd_region, struct bio *bio); ^~~ I was already feeling uneasy about trying to squeeze this into v5.2, but this warning and the continued drip of comments leads me to conclude that this driver would do well to wait one more development cycle. Lets close out the final fixups and let this driver soak in -next. Then for the v5.3 cycle I'll redouble my efforts towards the goal of closing patch acceptance at the -rc6 / -rc7 development milestone.