From: Dan Williams <dan.j.williams@intel.com>
To: Boaz Harrosh <boaz@plexistor.com>
Cc: Christoph Hellwig <hch@lst.de>,
linux-nvdimm <linux-nvdimm@ml01.01.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
X86 ML <x86@kernel.org>, Jens Axboe <axboe@kernel.dk>
Subject: Re: [Linux-nvdimm] [PATCH] pmem: Add prints at module load and unload
Date: Thu, 2 Apr 2015 08:39:50 -0700 [thread overview]
Message-ID: <CAPcyv4gRONdKn7bi2gS7RWWrNT=YuAPk-wNtJy_n_BTQq--LVw@mail.gmail.com> (raw)
In-Reply-To: <551D60BE.1070101@plexistor.com>
On Thu, Apr 2, 2015 at 8:31 AM, Boaz Harrosh <boaz@plexistor.com> wrote:
> Hi Christoph, Ingo
>
> Please consider this small patch below just a small print at module
> load/unload so to know at user systems how things progressed.
> As it is now, we know nothing. For any other disk kind we have two
> tuns of prints.
>
> ---
> From: Boaz Harrosh <boaz@plexistor.com>
> Date: Thu, 2 Apr 2015 16:43:48 +0300
> Subject: [PATCH] pmem: Add prints at module load and unload
>
> When debugging people's systems it is helpful
> to see what went on. The load and unload of pmem is
> an important event.
>
> The importance is the number of loaded devices and
> error status. The exact device's addresses created
> we can see from the other prints at e820 so no need
> to duplicate this information.
>
> While at it fix up a small issue with rw flags.
Separate patch for fixes please.
>
> Signed-off-by: Boaz Harrosh <boaz@plexistor.com>
> ---
> drivers/block/pmem.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/block/pmem.c b/drivers/block/pmem.c
> index 988f384..3f15fbc 100644
> --- a/drivers/block/pmem.c
> +++ b/drivers/block/pmem.c
> @@ -91,8 +91,9 @@ static int pmem_rw_page(struct block_device *bdev, sector_t sector,
> {
> struct pmem_device *pmem = bdev->bd_disk->private_data;
>
> + rw &= WRITE;
> pmem_do_bvec(pmem, page, PAGE_CACHE_SIZE, 0, rw, sector);
> - page_endio(page, rw & WRITE, 0);
> + page_endio(page, rw, 0);
>
> return 0;
> }
> @@ -248,6 +249,9 @@ static int __init pmem_init(void)
> error = platform_driver_register(&pmem_driver);
> if (error)
> unregister_blkdev(pmem_major, "pmem");
> +
> + pr_info("pmem: init %d devices => %d\n",
> + atomic_read(&pmem_index), error);
If anything I think these should be dev_dbg().
next prev parent reply other threads:[~2015-04-02 15:39 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-01 7:12 another pmem variant V3 Christoph Hellwig
2015-04-01 7:12 ` [PATCH 1/2] x86: add support for the non-standard protected e820 type Christoph Hellwig
2015-04-01 14:25 ` [PATCH] SQUASHME: Fixes to e820 handling of pmem Boaz Harrosh
2015-04-02 9:30 ` Christoph Hellwig
2015-04-02 9:37 ` Ingo Molnar
2015-04-02 9:40 ` Christoph Hellwig
2015-04-02 11:18 ` Christoph Hellwig
2015-04-02 11:20 ` Boaz Harrosh
2015-04-02 20:23 ` [PATCH 1/2] x86: add support for the non-standard protected e820 type Yinghai Lu
2015-04-03 16:14 ` [Linux-nvdimm] " Toshi Kani
2015-04-03 17:12 ` Yinghai Lu
2015-04-03 20:54 ` Toshi Kani
2015-04-04 9:40 ` Ingo Molnar
2015-04-05 7:44 ` Yinghai Lu
2015-04-06 7:27 ` Ingo Molnar
2015-04-06 17:29 ` Toshi Kani
2015-04-06 18:26 ` Yinghai Lu
2015-04-06 18:23 ` Toshi Kani
2015-04-05 9:18 ` Boaz Harrosh
2015-04-05 20:06 ` Yinghai Lu
2015-04-06 7:16 ` Boaz Harrosh
2015-04-06 15:55 ` Christoph Hellwig
2015-04-01 7:12 ` [PATCH 2/2] pmem: add a driver for persistent memory Christoph Hellwig
2015-04-01 15:18 ` Boaz Harrosh
2015-04-02 9:32 ` Christoph Hellwig
2015-04-02 15:31 ` [PATCH] pmem: Add prints at module load and unload Boaz Harrosh
2015-04-02 15:39 ` Dan Williams [this message]
2015-04-02 15:47 ` [Linux-nvdimm] " Boaz Harrosh
2015-04-02 16:01 ` Dan Williams
2015-04-02 16:44 ` Christoph Hellwig
2015-04-05 8:50 ` Boaz Harrosh
2015-04-07 15:19 ` Christoph Hellwig
2015-04-07 15:34 ` Boaz Harrosh
2015-04-07 15:46 ` [PATCH A+B] " Boaz Harrosh
2015-04-07 15:47 ` [PATCH 1A] pmem: Add prints at pmem_probe/remove Boaz Harrosh
2015-04-07 15:47 ` [PATCH 1B] pmem: Add prints at module load and unload Boaz Harrosh
2015-04-13 9:05 ` [PATCH A+B] " Greg KH
2015-04-13 12:05 ` Boaz Harrosh
2015-04-13 12:36 ` Greg KH
2015-04-13 13:20 ` Boaz Harrosh
2015-04-13 13:36 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPcyv4gRONdKn7bi2gS7RWWrNT=YuAPk-wNtJy_n_BTQq--LVw@mail.gmail.com' \
--to=dan.j.williams@intel.com \
--cc=axboe@kernel.dk \
--cc=boaz@plexistor.com \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@ml01.01.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).