From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7914AC433E0 for ; Wed, 24 Jun 2020 01:03:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 56910214DB for ; Wed, 24 Jun 2020 01:03:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="KYVTXVXk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388316AbgFXBDu (ORCPT ); Tue, 23 Jun 2020 21:03:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387677AbgFXBDs (ORCPT ); Tue, 23 Jun 2020 21:03:48 -0400 Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 77C0CC061573 for ; Tue, 23 Jun 2020 18:03:48 -0700 (PDT) Received: by mail-ed1-x533.google.com with SMTP id t21so198798edr.12 for ; Tue, 23 Jun 2020 18:03:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Eo5cTIL37FpYiHosBDpvR4kZAwB7mWQXF34HqE6NXHo=; b=KYVTXVXkCqMbcVuFTDEDKDF/vl50d6y6AVcDR3VWHAdVtg0rVF+rufFQ1wEqaxVJxh SIb5YPrtFiiuP3U/USOvpvsCngwFcKcauttqEoZunWAugH4tljXQUnJSNiIjDNlSZE/Y 8vINYeh9lbMfW+YemTuHtIAKi4Sl9PXz4gZiOGRJUuGUwoyGoQmUiLV5cCSbIz4EaasJ 92s42xO9NEEqZm68/Q83e/Ak5uUYC6GXyyuUfu/VrtqYiplckhU03c0Vgvov8YbQnCav /XiD58yFRrnMH13HCsgJrnDk0K6+OaiL+fWCrT5lEA0dPZE6YPGCpL2dE8+4ZxvV249D 1a5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Eo5cTIL37FpYiHosBDpvR4kZAwB7mWQXF34HqE6NXHo=; b=WPRETzh+g0sJYrk/FdSJTouBK6eJv5F1pOFXrLO2wr7C2GmsKOagqFlH9w9dQvhHG5 mM9U1gWY1JyiAa4WrZXCE0l4+dBpIgUmEC9dAHU5m3g2rfXpdgUzpzJJZAzgEl0U4Icq AyBeVxyz0i/u0elpMW1oYA5JSnd2mDkvxXL00gFyO5KpyXf9BsVkwd0ZGbmoRArDIX20 7SDbkIoLJhsYLpGxksKOm6B6DKETFXpopbVHCp9SbiPa46b7QDSRribnryjimkEYWkaT KFnTDZOqCAy/5tGEO8zDQHk1+B/bNI5kcE6rCHqWwKi0nblnvsL4uTftiwHE1nk5II0E hqNQ== X-Gm-Message-State: AOAM5330s2nZClAEQokfaOACstha28Ew8oZwDet4G0QWWXPWdFHQYsnS bpksOYTrF3BgjICgqg8s5LZAdqp3NLndfmcwiwU6Teb7 X-Google-Smtp-Source: ABdhPJwgEGyrPH+KoGgpyagYhDQWzp/X9Fcbf8BzrxMJ5Voz+JAHTmCCV7B6TldsquEEpVkTerwdy9arRqf3hvl6HiY= X-Received: by 2002:a50:d9cb:: with SMTP id x11mr9688647edj.93.1592960627165; Tue, 23 Jun 2020 18:03:47 -0700 (PDT) MIME-Version: 1.0 References: <1503686.1591113304@warthog.procyon.org.uk> <23219b787ed1c20a63017ab53839a0d1c794ec53.camel@intel.com> <3015561.1592960116@warthog.procyon.org.uk> In-Reply-To: <3015561.1592960116@warthog.procyon.org.uk> From: Dan Williams Date: Tue, 23 Jun 2020 18:03:36 -0700 Message-ID: Subject: Re: [GIT PULL] General notification queue and key notifications To: David Howells Cc: "torvalds@linux-foundation.org" , "raven@themaw.net" , "kzak@redhat.com" , "jarkko.sakkinen@linux.intel.com" , "linux-nvdimm@lists.01.org" , "dray@redhat.com" , "swhiteho@redhat.com" , "linux-kernel@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "mszeredi@redhat.com" , "jlayton@redhat.com" , "viro@zeniv.linux.org.uk" , "andres@anarazel.de" , "keyrings@vger.kernel.org" , "christian.brauner@ubuntu.com" Content-Type: text/plain; charset="UTF-8" Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Tue, Jun 23, 2020 at 5:55 PM David Howells wrote: > > Dan Williams wrote: > > > > This commit: > > > > > > > keys: Make the KEY_NEED_* perms an enum rather than a mask > > > > > > ...upstream as: > > > > > > 8c0637e950d6 keys: Make the KEY_NEED_* perms an enum rather than a mask > > > > > > ...triggers a regression in the libnvdimm unit test that exercises the > > > encrypted keys used to store nvdimm passphrases. It results in the > > > below warning. > > > > This regression is still present in tip of tree. David, have you had a > > chance to take a look? > > nvdimm_lookup_user_key() needs to indicate to lookup_user_key() what it wants > the key for so that the appropriate security checks can take place in SELinux > and Smack. Note that I have a patch in the works that changes this still > further. > > Does setting the third argument of lookup_user_key() to KEY_NEED_SEARCH work > for you? It does, thanks. Shall I wait for your further reworks to fix this for v5.8, or is that v5.9 material?