Linux-Fsdevel Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] fs/dax: Convert to use vmf_error()
@ 2019-01-04 19:24 Souptick Joarder
  2019-01-14  4:28 ` Souptick Joarder
  2019-01-14  8:58 ` Jan Kara
  0 siblings, 2 replies; 9+ messages in thread
From: Souptick Joarder @ 2019-01-04 19:24 UTC (permalink / raw)
  To: willy, zwisler, jack, viro; +Cc: linux-fsdevel, linux-kernel

This code is converted to use vmf_error().

Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
---
 fs/dax.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/fs/dax.c b/fs/dax.c
index 48132ec..ed39161 100644
--- a/fs/dax.c
+++ b/fs/dax.c
@@ -1220,9 +1220,7 @@ static vm_fault_t dax_fault_return(int error)
 {
 	if (error == 0)
 		return VM_FAULT_NOPAGE;
-	if (error == -ENOMEM)
-		return VM_FAULT_OOM;
-	return VM_FAULT_SIGBUS;
+	return vmf_error(error);
 }
 
 /*
-- 
1.9.1

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] fs/dax: Convert to use vmf_error()
  2019-01-04 19:24 [PATCH] fs/dax: Convert to use vmf_error() Souptick Joarder
@ 2019-01-14  4:28 ` Souptick Joarder
  2019-01-14  4:28   ` Souptick Joarder
  2019-01-14  8:58 ` Jan Kara
  1 sibling, 1 reply; 9+ messages in thread
From: Souptick Joarder @ 2019-01-14  4:28 UTC (permalink / raw)
  To: Matthew Wilcox, zwisler, Jan Kara, Al Viro; +Cc: linux-fsdevel, linux-kernel

On Sat, Jan 5, 2019 at 12:50 AM Souptick Joarder <jrdr.linux@gmail.com> wrote:
>
> This code is converted to use vmf_error().
>
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>

Any comment on this patch ?
> ---
>  fs/dax.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/fs/dax.c b/fs/dax.c
> index 48132ec..ed39161 100644
> --- a/fs/dax.c
> +++ b/fs/dax.c
> @@ -1220,9 +1220,7 @@ static vm_fault_t dax_fault_return(int error)
>  {
>         if (error == 0)
>                 return VM_FAULT_NOPAGE;
> -       if (error == -ENOMEM)
> -               return VM_FAULT_OOM;
> -       return VM_FAULT_SIGBUS;
> +       return vmf_error(error);
>  }
>
>  /*
> --
> 1.9.1
>

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] fs/dax: Convert to use vmf_error()
  2019-01-14  4:28 ` Souptick Joarder
@ 2019-01-14  4:28   ` Souptick Joarder
  0 siblings, 0 replies; 9+ messages in thread
From: Souptick Joarder @ 2019-01-14  4:28 UTC (permalink / raw)
  To: Matthew Wilcox, zwisler, Jan Kara, Al Viro; +Cc: linux-fsdevel, linux-kernel

On Sat, Jan 5, 2019 at 12:50 AM Souptick Joarder <jrdr.linux@gmail.com> wrote:
>
> This code is converted to use vmf_error().
>
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>

Any comment on this patch ?
> ---
>  fs/dax.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/fs/dax.c b/fs/dax.c
> index 48132ec..ed39161 100644
> --- a/fs/dax.c
> +++ b/fs/dax.c
> @@ -1220,9 +1220,7 @@ static vm_fault_t dax_fault_return(int error)
>  {
>         if (error == 0)
>                 return VM_FAULT_NOPAGE;
> -       if (error == -ENOMEM)
> -               return VM_FAULT_OOM;
> -       return VM_FAULT_SIGBUS;
> +       return vmf_error(error);
>  }
>
>  /*
> --
> 1.9.1
>

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] fs/dax: Convert to use vmf_error()
  2019-01-04 19:24 [PATCH] fs/dax: Convert to use vmf_error() Souptick Joarder
  2019-01-14  4:28 ` Souptick Joarder
@ 2019-01-14  8:58 ` Jan Kara
  2019-01-14  8:58   ` Jan Kara
  2019-01-14 22:30   ` Dan Williams
  1 sibling, 2 replies; 9+ messages in thread
From: Jan Kara @ 2019-01-14  8:58 UTC (permalink / raw)
  To: Souptick Joarder
  Cc: willy, zwisler, jack, viro, linux-fsdevel, linux-kernel, Dan Williams

On Sat 05-01-19 00:54:11, Souptick Joarder wrote:
> This code is converted to use vmf_error().
> 
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>

Dan, you are merging DAX patches these days. So probably you should add
yourself to 'FILESYSTEM DIRECT ACCESS (DAX)' in MAINTAINERs. Or I can start
picking patches for fsdax to my tree if you are too busy but I think your
tree is easier as there are less chances for conflicts etc.

In either case this patch looks OK to me so feel free to add

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza

> ---
>  fs/dax.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/fs/dax.c b/fs/dax.c
> index 48132ec..ed39161 100644
> --- a/fs/dax.c
> +++ b/fs/dax.c
> @@ -1220,9 +1220,7 @@ static vm_fault_t dax_fault_return(int error)
>  {
>  	if (error == 0)
>  		return VM_FAULT_NOPAGE;
> -	if (error == -ENOMEM)
> -		return VM_FAULT_OOM;
> -	return VM_FAULT_SIGBUS;
> +	return vmf_error(error);
>  }
>  
>  /*
> -- 
> 1.9.1
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] fs/dax: Convert to use vmf_error()
  2019-01-14  8:58 ` Jan Kara
@ 2019-01-14  8:58   ` Jan Kara
  2019-01-14 22:30   ` Dan Williams
  1 sibling, 0 replies; 9+ messages in thread
From: Jan Kara @ 2019-01-14  8:58 UTC (permalink / raw)
  To: Souptick Joarder
  Cc: willy, zwisler, jack, viro, linux-fsdevel, linux-kernel, Dan Williams

On Sat 05-01-19 00:54:11, Souptick Joarder wrote:
> This code is converted to use vmf_error().
> 
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>

Dan, you are merging DAX patches these days. So probably you should add
yourself to 'FILESYSTEM DIRECT ACCESS (DAX)' in MAINTAINERs. Or I can start
picking patches for fsdax to my tree if you are too busy but I think your
tree is easier as there are less chances for conflicts etc.

In either case this patch looks OK to me so feel free to add

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza

> ---
>  fs/dax.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/fs/dax.c b/fs/dax.c
> index 48132ec..ed39161 100644
> --- a/fs/dax.c
> +++ b/fs/dax.c
> @@ -1220,9 +1220,7 @@ static vm_fault_t dax_fault_return(int error)
>  {
>  	if (error == 0)
>  		return VM_FAULT_NOPAGE;
> -	if (error == -ENOMEM)
> -		return VM_FAULT_OOM;
> -	return VM_FAULT_SIGBUS;
> +	return vmf_error(error);
>  }
>  
>  /*
> -- 
> 1.9.1
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] fs/dax: Convert to use vmf_error()
  2019-01-14  8:58 ` Jan Kara
  2019-01-14  8:58   ` Jan Kara
@ 2019-01-14 22:30   ` Dan Williams
  2019-01-14 22:30     ` Dan Williams
  2019-02-05  2:33     ` Souptick Joarder
  1 sibling, 2 replies; 9+ messages in thread
From: Dan Williams @ 2019-01-14 22:30 UTC (permalink / raw)
  To: Jan Kara
  Cc: Souptick Joarder, Matthew Wilcox, Ross Zwisler, Al Viro,
	linux-fsdevel, Linux Kernel Mailing List

On Mon, Jan 14, 2019 at 12:59 AM Jan Kara <jack@suse.cz> wrote:
>
> On Sat 05-01-19 00:54:11, Souptick Joarder wrote:
> > This code is converted to use vmf_error().
> >
> > Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
>
> Dan, you are merging DAX patches these days. So probably you should add
> yourself to 'FILESYSTEM DIRECT ACCESS (DAX)' in MAINTAINERs.

Sounds good, I'll merge this and get MAINTAINERs fixed up.

> Or I can start
> picking patches for fsdax to my tree if you are too busy but I think your
> tree is easier as there are less chances for conflicts etc.
>
> In either case this patch looks OK to me so feel free to add
>
> Reviewed-by: Jan Kara <jack@suse.cz>
>
>                                                                 Honza
>
> > ---
> >  fs/dax.c | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/fs/dax.c b/fs/dax.c
> > index 48132ec..ed39161 100644
> > --- a/fs/dax.c
> > +++ b/fs/dax.c
> > @@ -1220,9 +1220,7 @@ static vm_fault_t dax_fault_return(int error)
> >  {
> >       if (error == 0)
> >               return VM_FAULT_NOPAGE;
> > -     if (error == -ENOMEM)
> > -             return VM_FAULT_OOM;
> > -     return VM_FAULT_SIGBUS;
> > +     return vmf_error(error);
> >  }
> >
> >  /*
> > --
> > 1.9.1
> >
> --
> Jan Kara <jack@suse.com>
> SUSE Labs, CR

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] fs/dax: Convert to use vmf_error()
  2019-01-14 22:30   ` Dan Williams
@ 2019-01-14 22:30     ` Dan Williams
  2019-02-05  2:33     ` Souptick Joarder
  1 sibling, 0 replies; 9+ messages in thread
From: Dan Williams @ 2019-01-14 22:30 UTC (permalink / raw)
  To: Jan Kara
  Cc: Souptick Joarder, Matthew Wilcox, Ross Zwisler, Al Viro,
	linux-fsdevel, Linux Kernel Mailing List

On Mon, Jan 14, 2019 at 12:59 AM Jan Kara <jack@suse.cz> wrote:
>
> On Sat 05-01-19 00:54:11, Souptick Joarder wrote:
> > This code is converted to use vmf_error().
> >
> > Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
>
> Dan, you are merging DAX patches these days. So probably you should add
> yourself to 'FILESYSTEM DIRECT ACCESS (DAX)' in MAINTAINERs.

Sounds good, I'll merge this and get MAINTAINERs fixed up.

> Or I can start
> picking patches for fsdax to my tree if you are too busy but I think your
> tree is easier as there are less chances for conflicts etc.
>
> In either case this patch looks OK to me so feel free to add
>
> Reviewed-by: Jan Kara <jack@suse.cz>
>
>                                                                 Honza
>
> > ---
> >  fs/dax.c | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/fs/dax.c b/fs/dax.c
> > index 48132ec..ed39161 100644
> > --- a/fs/dax.c
> > +++ b/fs/dax.c
> > @@ -1220,9 +1220,7 @@ static vm_fault_t dax_fault_return(int error)
> >  {
> >       if (error == 0)
> >               return VM_FAULT_NOPAGE;
> > -     if (error == -ENOMEM)
> > -             return VM_FAULT_OOM;
> > -     return VM_FAULT_SIGBUS;
> > +     return vmf_error(error);
> >  }
> >
> >  /*
> > --
> > 1.9.1
> >
> --
> Jan Kara <jack@suse.com>
> SUSE Labs, CR

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] fs/dax: Convert to use vmf_error()
  2019-01-14 22:30   ` Dan Williams
  2019-01-14 22:30     ` Dan Williams
@ 2019-02-05  2:33     ` Souptick Joarder
  2019-02-05  2:42       ` Dan Williams
  1 sibling, 1 reply; 9+ messages in thread
From: Souptick Joarder @ 2019-02-05  2:33 UTC (permalink / raw)
  To: Dan Williams
  Cc: Jan Kara, Matthew Wilcox, Ross Zwisler, Al Viro, linux-fsdevel,
	Linux Kernel Mailing List

Hi Dan,

On Tue, Jan 15, 2019 at 4:00 AM Dan Williams <dan.j.williams@intel.com> wrote:
>
> On Mon, Jan 14, 2019 at 12:59 AM Jan Kara <jack@suse.cz> wrote:
> >
> > On Sat 05-01-19 00:54:11, Souptick Joarder wrote:
> > > This code is converted to use vmf_error().
> > >
> > > Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> >
> > Dan, you are merging DAX patches these days. So probably you should add
> > yourself to 'FILESYSTEM DIRECT ACCESS (DAX)' in MAINTAINERs.
>
> Sounds good, I'll merge this and get MAINTAINERs fixed up.

This is not reflecting in linux-next. Is this queued for 5.1 ?

>
> > Or I can start
> > picking patches for fsdax to my tree if you are too busy but I think your
> > tree is easier as there are less chances for conflicts etc.
> >
> > In either case this patch looks OK to me so feel free to add
> >
> > Reviewed-by: Jan Kara <jack@suse.cz>
> >
> >                                                                 Honza
> >
> > > ---
> > >  fs/dax.c | 4 +---
> > >  1 file changed, 1 insertion(+), 3 deletions(-)
> > >
> > > diff --git a/fs/dax.c b/fs/dax.c
> > > index 48132ec..ed39161 100644
> > > --- a/fs/dax.c
> > > +++ b/fs/dax.c
> > > @@ -1220,9 +1220,7 @@ static vm_fault_t dax_fault_return(int error)
> > >  {
> > >       if (error == 0)
> > >               return VM_FAULT_NOPAGE;
> > > -     if (error == -ENOMEM)
> > > -             return VM_FAULT_OOM;
> > > -     return VM_FAULT_SIGBUS;
> > > +     return vmf_error(error);
> > >  }
> > >
> > >  /*
> > > --
> > > 1.9.1
> > >
> > --
> > Jan Kara <jack@suse.com>
> > SUSE Labs, CR

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] fs/dax: Convert to use vmf_error()
  2019-02-05  2:33     ` Souptick Joarder
@ 2019-02-05  2:42       ` Dan Williams
  0 siblings, 0 replies; 9+ messages in thread
From: Dan Williams @ 2019-02-05  2:42 UTC (permalink / raw)
  To: Souptick Joarder
  Cc: Jan Kara, Matthew Wilcox, Ross Zwisler, Al Viro, linux-fsdevel,
	Linux Kernel Mailing List

On Mon, Feb 4, 2019 at 6:33 PM Souptick Joarder <jrdr.linux@gmail.com> wrote:
>
> Hi Dan,
>
> On Tue, Jan 15, 2019 at 4:00 AM Dan Williams <dan.j.williams@intel.com> wrote:
> >
> > On Mon, Jan 14, 2019 at 12:59 AM Jan Kara <jack@suse.cz> wrote:
> > >
> > > On Sat 05-01-19 00:54:11, Souptick Joarder wrote:
> > > > This code is converted to use vmf_error().
> > > >
> > > > Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> > >
> > > Dan, you are merging DAX patches these days. So probably you should add
> > > yourself to 'FILESYSTEM DIRECT ACCESS (DAX)' in MAINTAINERs.
> >
> > Sounds good, I'll merge this and get MAINTAINERs fixed up.
>
> This is not reflecting in linux-next. Is this queued for 5.1 ?

Thanks for the ping, I'll get it queued up shortly.

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, back to index

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-04 19:24 [PATCH] fs/dax: Convert to use vmf_error() Souptick Joarder
2019-01-14  4:28 ` Souptick Joarder
2019-01-14  4:28   ` Souptick Joarder
2019-01-14  8:58 ` Jan Kara
2019-01-14  8:58   ` Jan Kara
2019-01-14 22:30   ` Dan Williams
2019-01-14 22:30     ` Dan Williams
2019-02-05  2:33     ` Souptick Joarder
2019-02-05  2:42       ` Dan Williams

Linux-Fsdevel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-fsdevel/0 linux-fsdevel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-fsdevel linux-fsdevel/ https://lore.kernel.org/linux-fsdevel \
		linux-fsdevel@vger.kernel.org linux-fsdevel@archiver.kernel.org
	public-inbox-index linux-fsdevel


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-fsdevel


AGPL code for this site: git clone https://public-inbox.org/ public-inbox