From: Dan Williams <dan.j.williams@intel.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Jan Kara <jack@suse.cz>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
linux-ext4 <linux-ext4@vger.kernel.org>,
Ross Zwisler <ross.zwisler@linux.intel.com>,
Linux MM <linux-mm@kvack.org>, Dave Jiang <dave.jiang@intel.com>
Subject: Re: [PATCH] mm: Fix warning in insert_pfn()
Date: Wed, 10 Oct 2018 17:46:22 -0700 [thread overview]
Message-ID: <CAPcyv4hB+rhST7QgNcT0QyLnYY3jQagd_tw8Lz=x3eO+TBFZxg@mail.gmail.com> (raw)
In-Reply-To: <20181010173015.ecb7c7ed1b2df729f058e346@linux-foundation.org>
On Wed, Oct 10, 2018 at 5:37 PM Andrew Morton <akpm@linux-foundation.org> wrote:
>
> On Fri, 24 Aug 2018 17:45:42 +0200 Jan Kara <jack@suse.cz> wrote:
>
> > In DAX mode a write pagefault can race with write(2) in the following
> > way:
> >
> > CPU0 CPU1
> > write fault for mapped zero page (hole)
> > dax_iomap_rw()
> > iomap_apply()
> > xfs_file_iomap_begin()
> > - allocates blocks
> > dax_iomap_actor()
> > invalidate_inode_pages2_range()
> > - invalidates radix tree entries in given range
> > dax_iomap_pte_fault()
> > grab_mapping_entry()
> > - no entry found, creates empty
> > ...
> > xfs_file_iomap_begin()
> > - finds already allocated block
> > ...
> > vmf_insert_mixed_mkwrite()
> > - WARNs and does nothing because there
> > is still zero page mapped in PTE
> > unmap_mapping_pages()
> >
> > This race results in WARN_ON from insert_pfn() and is occasionally
> > triggered by fstest generic/344. Note that the race is otherwise
> > harmless as before write(2) on CPU0 is finished, we will invalidate page
> > tables properly and thus user of mmap will see modified data from
> > write(2) from that point on. So just restrict the warning only to the
> > case when the PFN in PTE is not zero page.
> >
> > ...
> >
> > --- a/mm/memory.c
> > +++ b/mm/memory.c
> > @@ -1787,10 +1787,15 @@ static int insert_pfn(struct vm_area_struct *vma, unsigned long addr,
> > * in may not match the PFN we have mapped if the
> > * mapped PFN is a writeable COW page. In the mkwrite
> > * case we are creating a writable PTE for a shared
> > - * mapping and we expect the PFNs to match.
> > + * mapping and we expect the PFNs to match. If they
> > + * don't match, we are likely racing with block
> > + * allocation and mapping invalidation so just skip the
> > + * update.
> > */
> > - if (WARN_ON_ONCE(pte_pfn(*pte) != pfn_t_to_pfn(pfn)))
> > + if (pte_pfn(*pte) != pfn_t_to_pfn(pfn)) {
> > + WARN_ON_ONCE(!is_zero_pfn(pte_pfn(*pte)));
> > goto out_unlock;
> > + }
> > entry = *pte;
>
> Shouldn't we just remove the warning? We know it happens and we know
> why it happens and we know it's harmless. What's the point in scaring
> people?
tl;dr let's keep it.
I think this fix effectively pushes this into "can't happen"
territory, but if it does our dax assumptions are off somewhere else.
So, I think this is useful for developers hacking around in the dax
code to make sure they aren't breaking some fundamental assumption.
prev parent reply other threads:[~2018-10-11 0:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-24 15:45 [PATCH] mm: Fix warning in insert_pfn() Jan Kara
2018-10-03 16:35 ` Theodore Y. Ts'o
2018-10-03 16:56 ` Dan Williams
2018-10-04 14:35 ` Theodore Y. Ts'o
2018-10-11 0:30 ` Andrew Morton
2018-10-11 0:46 ` Dan Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPcyv4hB+rhST7QgNcT0QyLnYY3jQagd_tw8Lz=x3eO+TBFZxg@mail.gmail.com' \
--to=dan.j.williams@intel.com \
--cc=akpm@linux-foundation.org \
--cc=dave.jiang@intel.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ross.zwisler@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).