From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A4DBC33CAF for ; Thu, 16 Jan 2020 18:09:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E91B924681 for ; Thu, 16 Jan 2020 18:09:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="Z9dKYGG/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2393451AbgAPSJf (ORCPT ); Thu, 16 Jan 2020 13:09:35 -0500 Received: from mail-ot1-f48.google.com ([209.85.210.48]:44342 "EHLO mail-ot1-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388231AbgAPSJe (ORCPT ); Thu, 16 Jan 2020 13:09:34 -0500 Received: by mail-ot1-f48.google.com with SMTP id h9so20168410otj.11 for ; Thu, 16 Jan 2020 10:09:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KQb8Uq0IKx193QyLS3C+yGAjzOMy3a3CukknBRN2elo=; b=Z9dKYGG/It3ZDq626KVAn3UYMJ8w5rR7FNp1xgY+lJV2JdQ8DWHIetf1F8KloLda3X 39gAmzG6xzkqr5D4Ak+0h08VxlZHpS0TnHAHHZwNZrxSD9H0o70ll3pjpzqbXTbh1DKL DNBT464rgyw5mNlpF54auwQ7W0YShGDSgsOZLiQe9UuUK/EI3rXInwadnnG1lGK7QCU1 3w5gr6gsDviIi8iAJ4m/+JCGUJ3agwdBGY3e7V1tUCcAsasgKFwzh4MHrwHdLzXIgLAk x0PHbDzD2veOuVMZQjGO+cEu0iHunQLVEGPuaT782qMLmcgX5LnyP/rsd3PiYSGCcLoS c59A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KQb8Uq0IKx193QyLS3C+yGAjzOMy3a3CukknBRN2elo=; b=YlNqxPKsLmMCrEWK8RDHBI/VyHm12v8mV2AcGLtRf/L+CXecxHjAELz9QFbBJY2RDU xxQoadXWEa3jjgGVW/pLxjrAB7OFCcrnpi0zlPa1Jqgg1yEtnkQQodx6vrEBSjyaywam K3e7+b6efTaMULwvLOeI7vbf7kx1XlZ667J9ZQKe9AxdinH63BV/xzVuOaa+Tn8+idxY kBRX9zhyJX7NaAso5CkL4XKoxnuju5YSniTTaV0jk7ne9Lqd0n5pOGykHR219jcYjUE3 FZv2JLx0TpgG3Y4fBPJEWykYy4/1g8aioVY98z55w0KK+M1LY9a+DkjsS1EavQSVXV4+ +sqg== X-Gm-Message-State: APjAAAX6QNaSOsBdFVzWvHq9HDdDzNEkzLxiC+6/EObULU8Ws/orfii9 DLjPTThvtuzqfpffoQAHOD52TIRhYxqzPV2bb9+W4A== X-Google-Smtp-Source: APXvYqyXr3lS+JZj9aYaGZcaZ677aNc3G5lICFsM5cpGfCF42dv3olbejurJoFC1AmwOnpAVRiOEEAY2CuZWxYa6P3Q= X-Received: by 2002:a9d:6f11:: with SMTP id n17mr3079638otq.126.1579198173237; Thu, 16 Jan 2020 10:09:33 -0800 (PST) MIME-Version: 1.0 References: <20200106181117.GA16248@redhat.com> <20200116145403.GB25291@redhat.com> In-Reply-To: <20200116145403.GB25291@redhat.com> From: Dan Williams Date: Thu, 16 Jan 2020 10:09:22 -0800 Message-ID: Subject: Re: dax: Get rid of fs_dax_get_by_host() helper To: Vivek Goyal Cc: linux-fsdevel , Linux Kernel Mailing List , linux-nvdimm Content-Type: text/plain; charset="UTF-8" Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, Jan 16, 2020 at 6:54 AM Vivek Goyal wrote: > > On Mon, Jan 06, 2020 at 01:11:17PM -0500, Vivek Goyal wrote: > > Looks like nobody is using fs_dax_get_by_host() except fs_dax_get_by_bdev() > > and it can easily use dax_get_by_host() instead. > > > > IIUC, fs_dax_get_by_host() was only introduced so that one could compile > > with CONFIG_FS_DAX=n and CONFIG_DAX=m. fs_dax_get_by_bdev() achieves > > the same purpose and hence it looks like fs_dax_get_by_host() is not > > needed anymore. > > > > Signed-off-by: Vivek Goyal > > Hi Dan, > > Ping for this patch. How does it look to you. If you don't have concerns, > can you please take it in your tree. Yes, looks good and applied.