From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Williams Subject: Re: [PATCH v3 05/11] scatterlist: use sg_phys() Date: Mon, 11 May 2015 22:44:25 -0700 Message-ID: References: <20150512042629.11521.70356.stgit@dwillia2-desk3.amr.corp.intel.com> <20150512042956.11521.32457.stgit@dwillia2-desk3.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: "linux-kernel@vger.kernel.org" , linux-arch@vger.kernel.org, Jens Axboe , Rik van Riel , linux-nvdimm , david , Christoph Hellwig , Mel Gorman , j.glisse@gmail.com, linux-fsdevel , Andrew Morton , Ingo Molnar To: Julia Lawall Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Mon, May 11, 2015 at 10:24 PM, Julia Lawall wrote: > > > On Tue, 12 May 2015, Dan Williams wrote: > >> Coccinelle cleanup to replace open coded sg to physical address >> translations. This is in preparation for introducing scatterlists that >> reference pfn(s) without a backing struct page. >> >> // sg_phys.cocci: convert usage page_to_phys(sg_page(sg)) to sg_phys(sg) >> // usage: make coccicheck COCCI=sg_phys.cocci MODE=patch >> >> virtual patch >> virtual report >> virtual org > > Just for information, you don't need the three lines above. There are ony > useful when you want the semantic patch to support several kinds of > output. > Ok, I think I added them from copying a coccicheck script, and if I delete virtual patch I get "virtual rule patch not supported" when running: make coccicheck COCCI=sg_phys.cocci MODE=patch I suspect I am invoking it wrong.