From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A850DC33C9E for ; Tue, 14 Jan 2020 20:39:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 72ED224670 for ; Tue, 14 Jan 2020 20:39:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="1ufiHoIh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728834AbgANUjM (ORCPT ); Tue, 14 Jan 2020 15:39:12 -0500 Received: from mail-ot1-f68.google.com ([209.85.210.68]:35395 "EHLO mail-ot1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727102AbgANUjM (ORCPT ); Tue, 14 Jan 2020 15:39:12 -0500 Received: by mail-ot1-f68.google.com with SMTP id i15so14007205oto.2 for ; Tue, 14 Jan 2020 12:39:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KIZnzMCbYIPyWmmiZXOrwZsr2d1DaLuYf9PqBFFGxaY=; b=1ufiHoIhgkel1wNgfe5RR02iDJ6+fd8UzlDlpmsKFP4dFT9Zw+z+eHe5IHCwBCzia3 Qx3uIUdT99fmuIsed3Wcx0ZiytVs24h1TKYzEHptbEJN6KLwBLnismJWzCM54qIzbXng 6i+ainEaEBsD70PzhoIWMZ4fJhRG9/48EC7wGC+l3Tme4CNXCr+PDkn9oDjPuVkiudiu Jx7Hin+lVNC4afdBHw5tEOHqQLhQ+LCEm1bcbgLD2uj8DLGYhrZaQksVeFHTnazOxnuZ Kf5qJe/0whlXEMBDWBNM1CA1AAsAXa05zB+qlcDBZa7WUgJ3Wn6b+JSCmcNfsshtiJ1A CETA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KIZnzMCbYIPyWmmiZXOrwZsr2d1DaLuYf9PqBFFGxaY=; b=qshjyOE7gjC4ZyN8sAQgHPg5vFTbGIB7nYHeDJS2L4r1JCM4w+/K1B92705RQ7d2OA ZkSN5YuSmxXXOFGqIhPYfddDsLzXddiNCxXnIRXaT6eeWWH9F7RBQP179Kgej1PsXhU3 uIDstp8hgsLievNtvysDWshSZfWXvU3KYdvyuYV9GKjI+nXLK2IxlxGWYLJtrWm3qjLF HHjshh6vGZE9zgPP8DiGRWcWjY4B0q8I1GcmhRA8XRREIGyMUfzZSMhMgrNHgp6Gse0E avhtY7TqIsHFKnJfSJGeEGErFdRpSfPXBDB4v+ORqPNy5o7ezLQ0Ka8wKVnReBkSJvwX zMDQ== X-Gm-Message-State: APjAAAWeOYwnpzxCyJUVQkkq4IYjApplQbKiYIMGrd/8rurS/m5SFlti G7YHuJEgGkYLOy6C1GF7RCGPqWX4zRGWruJq09v1HSY6 X-Google-Smtp-Source: APXvYqzvyu/O19EV+W3nd5Qbhe0VPu8Zpxx4j6lAGURR9nwfPKNQXF393TmIiEgkujYPUIcgpRgr0BZ6QoEDec2+nxI= X-Received: by 2002:a9d:68d3:: with SMTP id i19mr130746oto.71.1579034351613; Tue, 14 Jan 2020 12:39:11 -0800 (PST) MIME-Version: 1.0 References: <20200107125159.GA15745@infradead.org> <20200107170731.GA472641@magnolia> <20200107180101.GC15920@redhat.com> <20200107183307.GD15920@redhat.com> <20200109112447.GG27035@quack2.suse.cz> <20200114203138.GA3145@redhat.com> In-Reply-To: <20200114203138.GA3145@redhat.com> From: Dan Williams Date: Tue, 14 Jan 2020 12:39:00 -0800 Message-ID: Subject: Re: [PATCH 01/19] dax: remove block device dependencies To: Vivek Goyal Cc: Jan Kara , "Darrick J. Wong" , Christoph Hellwig , Dave Chinner , Miklos Szeredi , linux-nvdimm , Linux Kernel Mailing List , "Dr. David Alan Gilbert" , virtio-fs@redhat.com, Stefan Hajnoczi , linux-fsdevel Content-Type: text/plain; charset="UTF-8" Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Tue, Jan 14, 2020 at 12:31 PM Vivek Goyal wrote: > > On Thu, Jan 09, 2020 at 12:03:01PM -0800, Dan Williams wrote: > > On Thu, Jan 9, 2020 at 3:27 AM Jan Kara wrote: > > > > > > On Tue 07-01-20 10:49:55, Dan Williams wrote: > > > > On Tue, Jan 7, 2020 at 10:33 AM Vivek Goyal wrote: > > > > > W.r.t partitioning, bdev_dax_pgoff() seems to be the pain point where > > > > > dax code refers back to block device to figure out partition offset in > > > > > dax device. If we create a dax object corresponding to "struct block_device" > > > > > and store sector offset in that, then we could pass that object to dax > > > > > code and not worry about referring back to bdev. I have written some > > > > > proof of concept code and called that object "dax_handle". I can post > > > > > that code if there is interest. > > > > > > > > I don't think it's worth it in the end especially considering > > > > filesystems are looking to operate on /dev/dax devices directly and > > > > remove block entanglements entirely. > > > > > > > > > IMHO, it feels useful to be able to partition and use a dax capable > > > > > block device in same way as non-dax block device. It will be really > > > > > odd to think that if filesystem is on /dev/pmem0p1, then dax can't > > > > > be enabled but if filesystem is on /dev/mapper/pmem0p1, then dax > > > > > will work. > > > > > > > > That can already happen today. If you do not properly align the > > > > partition then dax operations will be disabled. This proposal just > > > > extends that existing failure domain to make all partitions fail to > > > > support dax. > > > > > > Well, I have some sympathy with the sysadmin that has /dev/pmem0 device, > > > decides to create partitions on it for whatever (possibly misguided) > > > reason and then ponders why the hell DAX is not working? And PAGE_SIZE > > > partition alignment is so obvious and widespread that I don't count it as a > > > realistic error case sysadmins would be pondering about currently. > > > > > > So I'd find two options reasonably consistent: > > > 1) Keep status quo where partitions are created and support DAX. > > > 2) Stop partition creation altogether, if anyones wants to split pmem > > > device further, he can use dm-linear for that (i.e., kpartx). > > > > > > But I'm not sure if the ship hasn't already sailed for option 2) to be > > > feasible without angry users and Linus reverting the change. > > > > Christoph? I feel myself leaning more and more to the "keep pmem > > partitions" camp. > > > > I don't see "drop partition support" effort ending well given the long > > standing "ext4 fails to mount when dax is not available" precedent. > > > > I think the next least bad option is to have a dax_get_by_host() > > variant that passes an offset and length pair rather than requiring a > > later bdev_dax_pgoff() to recall the offset. This also prevents > > needing to add another dax-device object representation. > > I am wondering what's the conclusion on this. I want to this to make > progress in some direction so that I can make progress on virtiofs DAX > support. I think we should at least try to delete the partition support and see if anyone screams. Have a module option to revert the behavior so people are not stuck waiting for the revert to land, but if it stays quiet then we're in a better place with that support pushed out of the dax core.