From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot0-f195.google.com ([74.125.82.195]:38382 "EHLO mail-ot0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754107AbeEORUM (ORCPT ); Tue, 15 May 2018 13:20:12 -0400 Received: by mail-ot0-f195.google.com with SMTP id n3-v6so1102951ota.5 for ; Tue, 15 May 2018 10:20:12 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20180515064906.GA29231@gmail.com> References: <20180514072603.GA14099@gmail.com> <20180515064906.GA29231@gmail.com> From: Dan Williams Date: Tue, 15 May 2018 10:20:11 -0700 Message-ID: Subject: Re: use memcpy_mcsafe() for copy_to_iter() (was: Re: [PATCH v3 0/9] Series short description) To: Ingo Molnar Cc: linux-nvdimm , "Luck, Tony" , Andrew Morton , Mike Snitzer , Peter Zijlstra , X86 ML , Linux Kernel Mailing List , Andy Lutomirski , Ingo Molnar , Borislav Petkov , =?UTF-8?Q?Mika_Penttil=C3=A4?= , linux-fsdevel , Thomas Gleixner , Linus Torvalds , Christoph Hellwig , Al Viro , Peter Zijlstra , Andy Lutomirski Content-Type: text/plain; charset="UTF-8" Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, May 14, 2018 at 11:49 PM, Ingo Molnar wrote: > > * Dan Williams wrote: > >> On Mon, May 14, 2018 at 12:26 AM, Ingo Molnar wrote: >> > >> > * Dan Williams wrote: >> > >> >> Ingo, Thomas, Al, any concerns with this series? >> > >> > Yeah, so: >> > >> > "[PATCH v3 0/9] Series short description" >> > >> > ... isn't the catchiest of titles to capture my [all too easily distracted] >> > attention! ;-) >> >> My bad! After that mistake it became a toss-up between more spam and >> hoping the distraction would not throw you off. >> >> > I have marked it now for -tip processing. Linus was happy with this and acked the >> > approach, right? >> >> I think "happy" is a strong word when it comes to x86 machine check >> handling. My interpretation is that he and Andy acquiesced that this >> is about the best we can do with dax+mce as things stand today. > > So, how would you like to go about this series? > > To help move it forward I applied the first 5 commits to tip:x86/dax, on a > vanilla v4.17-rc5 base, did some minor edits to the changelogs, tested it > superficially (I don't have DAX so this essentially means build tests) and > pushed out the result. Thanks for that. Technically speaking, you do have dax, but setting up our unit tests is currently not friction free, so I would not expect you to go through that effort. Hopefully we can revive 0day running our unit tests one of these days. > Barring some later generic-x86 regression (unlikely) this looks good to me - feel > free to cross-pull that branch into your DAX/nvdimm tree. > > Or we could apply the remaining changes to -tip too - your call. The remainder patches have developed a conflict with another topic branch in the nvdimm tree, in particular "dax: introduce a ->copy_to_iter dax operation". I think the best course is for me to rebase the remaining 4 on top of tip/x86/dax and carry the merge conflict through the nvdimm tree. > Thanks, > > Ingo Thanks!