From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 350FEC433DB for ; Tue, 5 Jan 2021 03:52:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E80BC229C5 for ; Tue, 5 Jan 2021 03:52:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728193AbhAEDv2 (ORCPT ); Mon, 4 Jan 2021 22:51:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42472 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728137AbhAEDv1 (ORCPT ); Mon, 4 Jan 2021 22:51:27 -0500 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E05AEC061574 for ; Mon, 4 Jan 2021 19:50:46 -0800 (PST) Received: by mail-ed1-x52c.google.com with SMTP id b2so29673887edm.3 for ; Mon, 04 Jan 2021 19:50:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=b3i2DWNklZVjsl2UAKCa7AqbN0KVFXiRrj/Leq+WDOM=; b=QaoV+dt85/SIxPaD152+bpRXhieIfNZjXCLFUmnjYeOVSlH2J6hfzWGAON68nNBgrD /TguU7C/InTWFGCWhMMaUvR7E8YseVqLQhvWeGBHfIum06L67uPE7MK4PTnqxNrhKbi0 Top9zLT03LMVUN9t9xou9mOwcAu0SfHQ8vG3cNhJZ94pMrW4w26tG2JgcA4Vz2Cr4+HC 8m1ps6dEEn5wYPuqceRcDZBtkNqB42Io6Hq+8OWaLe+fItq9KgaSbkU3ML5wcpih3N4Z i36QU52gQvhylBwEKNULGyufAdMV0f6PG3GdI2IvKEIxPWba7I2olzRfKUvZqdepRwUn agJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=b3i2DWNklZVjsl2UAKCa7AqbN0KVFXiRrj/Leq+WDOM=; b=XJmzP83LMji7iRLy5NpnAyRwyYRMfmd3sL/ygZk/36Ft9J3F2nS7cqbFkUDjkdXDvR ryXITpG2HyUMj6cfs6rlXThJQiynFrGTZg13OhPIha0m3daMO+ToPRJRnuhr6pNuwbeO uaeBHWYgsnrQWdqjDsVLttdMm+o6Yw+itGv2e8GL/3CSAa+m6tWD+n9SUvOBt52A3gI7 IxMiRMV8cVmzL1RnFYNn/JzCXYmiV5PrqdMK1An4Xds4Leq6Grd26LlZkIDW0qlXVsFz e0Pln6D063uwx9WYZnEm06P9NDnP4br3cqNW/yMD04HhDRO3t1DE6/LpX1gCZQwzHL8z TXuw== X-Gm-Message-State: AOAM532Bept+TP+0srJ0ZOhYiOG5LI5nJOhI0LTNwm3sl4uG4BKcGiDg MXWwZ+EZubDDO7Zu+JhymI7dzYWTcwQlciY4VYgHDZn25d8= X-Google-Smtp-Source: ABdhPJwknNce1uVDk7EBKnwBvIlU5uz+2znHV465a20iudsxykeAovWJHlAtM2Cs1s+X+Z7S8tkSSZkk+wewPh3CAo8= X-Received: by 2002:aa7:df0f:: with SMTP id c15mr75010622edy.354.1609818645726; Mon, 04 Jan 2021 19:50:45 -0800 (PST) MIME-Version: 1.0 References: <20210101042914.5313-1-rdunlap@infradead.org> In-Reply-To: From: Dan Williams Date: Mon, 4 Jan 2021 19:50:39 -0800 Message-ID: Subject: Re: [PATCH v2] fs/dax: include to fix build error on ARC To: Randy Dunlap Cc: Linux Kernel Mailing List , kernel test robot , Vineet Gupta , linux-snps-arc@lists.infradead.org, Vineet Gupta , Andrew Morton , Matthew Wilcox , Jan Kara , linux-fsdevel , linux-nvdimm Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Mon, Jan 4, 2021 at 7:47 PM Randy Dunlap wrote: > > On 1/4/21 12:13 PM, Dan Williams wrote: > > On Thu, Dec 31, 2020 at 8:29 PM Randy Dunlap wrote: > >> > >> fs/dax.c uses copy_user_page() but ARC does not provide that interface, > >> resulting in a build error. > >> > >> Provide copy_user_page() in (beside copy_page()) and > >> add to fs/dax.c to fix the build error. > >> > >> ../fs/dax.c: In function 'copy_cow_page_dax': > >> ../fs/dax.c:702:2: error: implicit declaration of function 'copy_user_page'; did you mean 'copy_to_user_page'? [-Werror=implicit-function-declaration] > >> > >> Fixes: cccbce671582 ("filesystem-dax: convert to dax_direct_access()") > >> Reported-by: kernel test robot > >> Signed-off-by: Randy Dunlap > >> Cc: Vineet Gupta > >> Cc: linux-snps-arc@lists.infradead.org > >> Cc: Dan Williams > >> Acked-by: Vineet Gupta > >> Cc: Andrew Morton > >> Cc: Matthew Wilcox > >> Cc: Jan Kara > >> Cc: linux-fsdevel@vger.kernel.org > >> Cc: linux-nvdimm@lists.01.org > >> --- > >> v2: rebase, add more Cc: > >> > >> arch/arc/include/asm/page.h | 1 + > >> fs/dax.c | 1 + > >> 2 files changed, 2 insertions(+) > >> > >> --- lnx-511-rc1.orig/fs/dax.c > >> +++ lnx-511-rc1/fs/dax.c > >> @@ -25,6 +25,7 @@ > >> #include > >> #include > >> #include > >> +#include > > > > I would expect this to come from one of the linux/ includes like > > linux/mm.h. asm/ headers are implementation linux/ headers are api. > > > > Once you drop that then the subject of this patch can just be "arc: > > add a copy_user_page() implementation", and handled by the arc > > maintainer (or I can take it with Vineet's ack). > > Got it. Thanks. > Vineet is copied. I expect that he will take the v3 patch. > > >> #include > > > > Yes, this one should have a linux/ api header to front it, but that's > > a cleanup for another day. > > That line is only part of the contextual diff in this patch. > I guess you are just commenting in general, along with your earlier > paragraph. Yes, I was prefetching a "...hey, but, there's an asm/ include right below this one?"