From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from zeniv.linux.org.uk ([195.92.253.2]:40764 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751022AbeEMVMC (ORCPT ); Sun, 13 May 2018 17:12:02 -0400 Date: Sun, 13 May 2018 22:12:00 +0100 To: linux-fsdevel@vger.kernel.org Subject: [RFC][PATCH] cramfs_lookup(): use d_splice_alias() Cc: , Pitre@ftp.linux.org.uk, Nicolas@ftp.linux.org.uk MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-Id: From: Al Viro Sender: linux-fsdevel-owner@vger.kernel.org List-ID: simpler code that way, actually Signed-off-by: Al Viro --- fs/cramfs/inode.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/fs/cramfs/inode.c b/fs/cramfs/inode.c index 017b0ab19bc4..4756e9daa0b2 100644 --- a/fs/cramfs/inode.c +++ b/fs/cramfs/inode.c @@ -808,10 +808,7 @@ static struct dentry *cramfs_lookup(struct inode *dir, struct dentry *dentry, un } out: mutex_unlock(&read_mutex); - if (IS_ERR(inode)) - return ERR_CAST(inode); - d_add(dentry, inode); - return NULL; + return d_splice_alias(inode, dentry); } static int cramfs_readpage(struct file *file, struct page *page) -- 2.11.0