From: Andreas Dilger <firstname.lastname@example.org> To: Eric Sandeen <email@example.com> Cc: Qu Wenruo <firstname.lastname@example.org>, Joshi <email@example.com>, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com Subject: Re: cross-fs copy support Date: Mon, 1 Oct 2018 13:51:09 -0600 [thread overview] Message-ID: <FE6394EC-5CB0-4A16-AAC6-97F465A4E50C@dilger.ca> (raw) In-Reply-To: <firstname.lastname@example.org> [-- Attachment #1: Type: text/plain, Size: 1723 bytes --] \x1d\b\x1d\x1dOn Oct 1, 2018, at 9:49 AM, Eric Sandeen <email@example.com> wrote: > > > On 10/1/18 9:48 AM, Qu Wenruo wrote: >> >> >> On 2018/10/1 下午10:32, Joshi wrote: >>> I was wondering about the cross-fs copy through copy_file_range. >> >> The term "cross-fs" looks pretty confusing. >> >> If you mean "cross-subvolume", then it should work without problem in btrfs. >> >> If you mean reflink across two different file systems (not matter the >> same fs type or not). >> Then it's impossible to work. > > I believe Joshi is talking about vfs_copy_file_range() not > vfs_clone_file range(), although _copy_ does call _clone_ if it can. > >> Reflink (clone_file_range) works by inserting data pointers into the >> filesystem other than really copying the data. >> Thus if the source is outside of the fs, it's really impossible to work, >> as the source pointer/data is completely out of control of the dest fs. > > Yes, I would expect there to be problems with his modified kernel > for a filesystem that supports clone_file_range, because > vfs_copy_file_range() will clone if possible, and this should fail across > filesystems. > > In general, though, I don't know for sure why we don't fall back to > do_splice_direct() across filesystems, although the filesystems that > implement their own ->copy_file_range ops may have their own, > further restrictions within their implementations. > > This call /is/ documented in the manpage as only being valid for > files on the same filesystem, though: > http://man7.org/linux/man-pages/man2/copy_file_range.2.html There was a patch to allow cross-mount copy for NFS, but it hasn't landed yet. Cheers, Andreas [-- Attachment #2: Message signed with OpenPGP --] [-- Type: application/pgp-signature, Size: 873 bytes --]
next prev parent reply other threads:[~2018-10-02 2:30 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-10-01 14:32 Joshi 2018-10-01 14:48 ` Qu Wenruo 2018-10-01 15:15 ` Joshi 2018-10-01 15:49 ` Eric Sandeen 2018-10-01 19:51 ` Andreas Dilger [this message] 2018-10-02 8:15 ` David Sterba 2018-10-02 15:19 ` Darrick J. Wong 2018-10-02 18:28 ` J. Bruce Fields
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=FE6394EC-5CB0-4A16-AAC6-97F465A4E50C@dilger.ca \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: cross-fs copy support' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).