From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa2.hgst.iphmx.com ([68.232.143.124]:56145 "EHLO esa2.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752493AbdKQTd1 (ORCPT ); Fri, 17 Nov 2017 14:33:27 -0500 From: Slava Dubeyko To: "tchou@synology.com" , Hin-Tak Leung CC: "linux-fsdevel@vger.kernel.org" Subject: RE: [PATCH] hfsplus: fix the bug that cannot recognize files with hangul file name Date: Fri, 17 Nov 2017 19:33:25 +0000 Message-ID: Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Hi Ting-Chang, Sorry, I need to reapet my e-mail. Could you please share the examples of incorrect and corect behavior? Are y= ou sure that we need in such fix because it is tne mount option. Hi Hin-Tak, Could you please test the fix? Thanks, Vyacheslav Dubeyko. >> From: Ting-Chang Hou >> Date: Fri, Nov 17, 2017 at 12:20 AM >> Subject: [PATCH] hfsplus: fix the bug that cannot recognize files with h= angul file name >> To: linux-fsdevel@vger.kernel.org >> Cc: Ting-Chang Hou >> >> The unicode of hangul from macOS is decomposed. There has a bug that >> mistake decomposed unicode for composed when change unicode to ascii, >> so it cannot recognize the hangul correctly. >> >> Signed-off-by: Ting-Chang Hou >> --- >> fs/hfsplus/unicode.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/fs/hfsplus/unicode.c b/fs/hfsplus/unicode.c >> index dfa90c2..2daf7b0 100644 >> --- a/fs/hfsplus/unicode.c >> +++ b/fs/hfsplus/unicode.c >> @@ -135,7 +135,7 @@ int hfsplus_uni2asc(struct super_block *sb, >> ustrlen =3D be16_to_cpu(ustr->length); >> len =3D *len_p; >> ce1 =3D NULL; >> - compose =3D !test_bit(HFSPLUS_SB_NODECOMPOSE, &HFSPLUS_SB(sb)->f= lags); >> + compose =3D test_bit(HFSPLUS_SB_NODECOMPOSE, &HFSPLUS_SB(sb)->fl= ags); >> >> while (ustrlen > 0) { >> c0 =3D be16_to_cpu(*ip++); >> -- >> 2.7.4