From: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
To: "dsterba@suse.cz" <dsterba@suse.cz>
Cc: Johannes Thumshirn <jth@kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
Eric Biggers <ebiggers@google.com>,
Richard Weinberger <richard@nod.at>,
Jonathan Corbet <corbet@lwn.net>
Subject: Re: [PATCH v3 3/3] btrfs: document btrfs authentication
Date: Mon, 25 May 2020 11:44:06 +0000 [thread overview]
Message-ID: <SN4PR0401MB35989EECCB34AFBFED58E20D9BB30@SN4PR0401MB3598.namprd04.prod.outlook.com> (raw)
In-Reply-To: 20200525112622.GP18421@suse.cz
On 25/05/2020 13:27, David Sterba wrote:
>>> Suggested fix is to have a data block "header", with similar contents as
>>> the metadata blocks, eg.
>>>
>>> struct btrfs_hash_header {
>>> u8 fsid[BTRFS_FSID_SIZE];
>>> u8 chunk_tree_uuid[BTRFS_UUID_SIZE];
>>> __le64 generation;
>>> };
>>>
>>> Perhaps also with some extra item for future extensions, set to zeros
>>> for now.
>>
>> This addition would be possible, yes. But if we'd add this header to every
>> checksum in the checksum tree it would be an incompatible on-disk format
>> change.
>
> No. It's only in-memory and is built from known pieces of information
> exactly to avoid storing it on disk.
>
Ah OK, now I get what you meant. This should then be only for the authenticated
FS I guess.
next prev parent reply other threads:[~2020-05-25 11:44 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-14 9:24 [PATCH v3 0/3] Add file-system authentication to BTRFS Johannes Thumshirn
2020-05-14 9:24 ` [PATCH v3 1/3] btrfs: rename btrfs_parse_device_options back to btrfs_parse_early_options Johannes Thumshirn
2020-05-14 9:24 ` [PATCH v3 2/3] btrfs: add authentication support Johannes Thumshirn
2020-05-27 13:24 ` David Sterba
2020-05-27 13:54 ` Johannes Thumshirn
2020-05-27 14:01 ` Johannes Thumshirn
2020-05-27 18:04 ` Johannes Thumshirn
2020-06-01 14:30 ` David Sterba
2020-06-01 14:35 ` David Sterba
2020-05-14 9:24 ` [PATCH v3 3/3] btrfs: document btrfs authentication Johannes Thumshirn
2020-05-14 12:26 ` Jonathan Corbet
2020-05-14 14:54 ` Johannes Thumshirn
2020-05-14 15:14 ` Richard Weinberger
2020-05-14 16:00 ` Jonathan Corbet
2020-05-14 16:05 ` Richard Weinberger
2020-05-24 19:55 ` David Sterba
2020-05-25 10:57 ` Johannes Thumshirn
2020-05-25 11:26 ` David Sterba
2020-05-25 11:44 ` Johannes Thumshirn [this message]
2020-05-25 13:10 ` [PATCH v3 0/3] Add file-system authentication to BTRFS David Sterba
2020-05-26 7:50 ` Johannes Thumshirn
2020-05-26 11:53 ` David Sterba
2020-05-26 12:44 ` Johannes Thumshirn
2020-06-01 14:59 ` David Sterba
2020-05-27 2:08 ` Qu Wenruo
2020-05-27 11:27 ` David Sterba
2020-05-27 11:58 ` Qu Wenruo
2020-05-27 13:11 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN4PR0401MB35989EECCB34AFBFED58E20D9BB30@SN4PR0401MB3598.namprd04.prod.outlook.com \
--to=johannes.thumshirn@wdc.com \
--cc=corbet@lwn.net \
--cc=dsterba@suse.cz \
--cc=ebiggers@google.com \
--cc=jth@kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).