From: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To: Jason Yan <yanaijie@huawei.com>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Cc: "miaoxie@huawei.com" <miaoxie@huawei.com>,
"zhaohongjiang@huawei.com" <zhaohongjiang@huawei.com>,
Christoph Hellwig <hch@lst.de>, Ming Lei <ming.lei@redhat.com>
Subject: Re: [PATCH v2] block: fix the return errno for direct IO
Date: Fri, 12 Apr 2019 03:37:26 +0000 [thread overview]
Message-ID: <SN6PR04MB45276A5F93D629088DE810FC86280@SN6PR04MB4527.namprd04.prod.outlook.com> (raw)
In-Reply-To: 20190412020916.1160-1-yanaijie@huawei.com
Looks good.
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
On 4/11/19 6:52 PM, Jason Yan wrote:
> If the last bio returned is not dio->bio, the status of the bio will
> not assigned to dio->bio if it is error. This will cause the whole IO
> status wrong.
>
> ksoftirqd/21-117 [021] ..s. 4017.966090: 8,0 C N 4883648 [0]
> <idle>-0 [018] ..s. 4017.970888: 8,0 C WS 4924800 + 1024 [0]
> <idle>-0 [018] ..s. 4017.970909: 8,0 D WS 4935424 + 1024 [<idle>]
> <idle>-0 [018] ..s. 4017.970924: 8,0 D WS 4936448 + 321 [<idle>]
> ksoftirqd/21-117 [021] ..s. 4017.995033: 8,0 C R 4883648 + 336 [65475]
> ksoftirqd/21-117 [021] d.s. 4018.001988: myprobe1: (blkdev_bio_end_io+0x0/0x168) bi_status=7
> ksoftirqd/21-117 [021] d.s. 4018.001992: myprobe: (aio_complete_rw+0x0/0x148) x0=0xffff802f2595ad80 res=0x12a000 res2=0x0
>
> We always have to assign bio->bi_status to dio->bio.bi_status because we
> will only check dio->bio.bi_status when we return the whole IO to
> the upper layer.
>
> Fixes: 542ff7bf18c6 ("block: new direct I/O implementation")
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Jens Axboe <axboe@kernel.dk>
> Cc: Ming Lei <ming.lei@redhat.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
> ---
>
> v2: remove white space changes
>
> fs/block_dev.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/fs/block_dev.c b/fs/block_dev.c
> index 78d3257435c0..24615c76c1d0 100644
> --- a/fs/block_dev.c
> +++ b/fs/block_dev.c
> @@ -307,10 +307,10 @@ static void blkdev_bio_end_io(struct bio *bio)
> struct blkdev_dio *dio = bio->bi_private;
> bool should_dirty = dio->should_dirty;
>
> - if (dio->multi_bio && !atomic_dec_and_test(&dio->ref)) {
> - if (bio->bi_status && !dio->bio.bi_status)
> - dio->bio.bi_status = bio->bi_status;
> - } else {
> + if (bio->bi_status && !dio->bio.bi_status)
> + dio->bio.bi_status = bio->bi_status;
> +
> + if (!dio->multi_bio || atomic_dec_and_test(&dio->ref)) {
> if (!dio->is_sync) {
> struct kiocb *iocb = dio->iocb;
> ssize_t ret;
>
prev parent reply other threads:[~2019-04-12 3:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-12 2:09 [PATCH v2] block: fix the return errno for direct IO Jason Yan
2019-04-12 2:43 ` Ming Lei
2019-04-12 3:22 ` Jens Axboe
2019-04-12 3:37 ` Chaitanya Kulkarni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN6PR04MB45276A5F93D629088DE810FC86280@SN6PR04MB4527.namprd04.prod.outlook.com \
--to=chaitanya.kulkarni@wdc.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=miaoxie@huawei.com \
--cc=ming.lei@redhat.com \
--cc=viro@zeniv.linux.org.uk \
--cc=yanaijie@huawei.com \
--cc=zhaohongjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).