From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80745C433DB for ; Wed, 17 Feb 2021 21:23:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 46F1064E6C for ; Wed, 17 Feb 2021 21:23:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232884AbhBQVXJ (ORCPT ); Wed, 17 Feb 2021 16:23:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52454 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233744AbhBQVWs (ORCPT ); Wed, 17 Feb 2021 16:22:48 -0500 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CDAC5C0613D6; Wed, 17 Feb 2021 13:22:08 -0800 (PST) Received: by mail-pj1-x1034.google.com with SMTP id fa16so59383pjb.1; Wed, 17 Feb 2021 13:22:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=sQzaNxAid9QvqVYhihsfh2vWMCoJ27PcKGw8kt1g66I=; b=p0QwrOctwd52hexap6KCKB3coo8XhqEMui5DoM+5kapBOCgvyAp7ekJdpeCpkuv7IO Kyq/cmtvDejQPhs7UFTwVYQGBE1U+C4HUmKE7W4yGgYjjD5Wv4ozQ7D+kSnc5LrVYTeW NvA45IpZf95mwZtcplJBAMyAqh2ftR73lmDJka9nasDdXC2zXNSRlklCdPXnZPoLUVrg 4VTC1SsTKN4i88U4NYVKpB8ikdmEKhy2ZOLoMyyQFCrbBjzSTISK2fAdTTn0tGMC692s Ik9IHq3dovW92AIGU47FexYjZGQyAAwP5VTWHbyxBq2BdjDtKjXIzIF+LlwyQulVCA0N 0a/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=sQzaNxAid9QvqVYhihsfh2vWMCoJ27PcKGw8kt1g66I=; b=H9U/XrgKaERkHzKXDIpnPUAYtNrQPfbJrFnRnKu5lTGYnUv3TMiIMDJSqldV4CmeYD wYL9nGouoy9G+ZPKU3ZO/EWjWqg6rv+TZut4VqnpJkZgfOnq7wrQJa70CrPtcwYE7hdo bC87v++sBSNOCLYWAF59Mn0AhHA7o0J8SE5/BAHkIFENsR52h8ScGNxk6zZfAD063npi O8CmMj0t9VIgUBsAkr1SEliNuF7qAVersqw/T1lWZ1z009vi1SqT7YEzrVumjEaaKxP7 Gm8i5lpD3HAeJzfeiWdXbJDWtxA3CsTwHalARa92KqOnogIgyBDjCpVKH6DvMnuiR8xb gkyg== X-Gm-Message-State: AOAM5334LeXS9907V8Ci4FF34CCCiSIw/REipBnqsERwmFcCg0TM56mT xC5PfFfrO1f8Xt5v9zeBEO0= X-Google-Smtp-Source: ABdhPJyneviUq4ugz6XKjWdZ8xrW7jmT9QscfAaiU+m4gfcMOT7KkVass8VqD3YPzLbVH6LFh50zCA== X-Received: by 2002:a17:902:f54e:b029:e3:5af0:d98f with SMTP id h14-20020a170902f54eb02900e35af0d98fmr920942plf.5.1613596928463; Wed, 17 Feb 2021 13:22:08 -0800 (PST) Received: from google.com ([2620:15c:211:201:157d:8a19:5427:ea9e]) by smtp.gmail.com with ESMTPSA id 184sm3475254pgi.92.2021.02.17.13.22.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Feb 2021 13:22:07 -0800 (PST) Sender: Minchan Kim Date: Wed, 17 Feb 2021 13:22:05 -0800 From: Minchan Kim To: Matthew Wilcox Cc: Michal Hocko , Andrew Morton , linux-mm , LKML , cgoldswo@codeaurora.org, linux-fsdevel@vger.kernel.org, david@redhat.com, vbabka@suse.cz, viro@zeniv.linux.org.uk, joaodias@google.com Subject: Re: [RFC 1/2] mm: disable LRU pagevec during the migration temporarily Message-ID: References: <20210216170348.1513483-1-minchan@kernel.org> <20210217211143.GN2858050@casper.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210217211143.GN2858050@casper.infradead.org> Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, Feb 17, 2021 at 09:11:43PM +0000, Matthew Wilcox wrote: > On Wed, Feb 17, 2021 at 12:51:25PM -0800, Minchan Kim wrote: > > I'd like to avoid atomic operation if we could. > > Why do you think that the spinlock is better? > Michal suggested atomic_inc in writeside and atomic_read in readside. I wanted to avoid atomic operation in readside path. You are suggesting atomic for writeside and just read(not atomic_read) in readside?