From: Alessio Balsini <balsini@android.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: Alessio Balsini <balsini@android.com>,
Akilesh Kailash <akailash@google.com>,
Amir Goldstein <amir73il@gmail.com>,
Antonio SJ Musumeci <trapexit@spawn.link>,
David Anderson <dvander@google.com>,
Giuseppe Scrivano <gscrivan@redhat.com>,
Jann Horn <jannh@google.com>, Jens Axboe <axboe@kernel.dk>,
Martijn Coenen <maco@android.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Paul Lawrence <paullawrence@google.com>,
Peng Tao <bergwolf@gmail.com>,
Stefano Duo <duostefano93@gmail.com>,
Zimuzo Ezeozue <zezeozue@google.com>, wuyan <wu-yan@tcl.com>,
fuse-devel <fuse-devel@lists.sourceforge.net>,
kernel-team <kernel-team@android.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND V12 2/8] fuse: 32-bit user space ioctl compat for fuse device
Date: Mon, 1 Mar 2021 12:26:26 +0000 [thread overview]
Message-ID: <YDzdcnS1JJWboFYN@google.com> (raw)
In-Reply-To: <CAJfpegviqcgtE4qRHZFy6xdL6Re7gs30TV1epkn7cvUu3A4hqw@mail.gmail.com>
On Wed, Feb 17, 2021 at 11:21:04AM +0100, Miklos Szeredi wrote:
> On Mon, Jan 25, 2021 at 4:31 PM Alessio Balsini <balsini@android.com> wrote:
> >
> > With a 64-bit kernel build the FUSE device cannot handle ioctl requests
> > coming from 32-bit user space.
> > This is due to the ioctl command translation that generates different
> > command identifiers that thus cannot be used for direct comparisons
> > without proper manipulation.
> >
> > Explicitly extract type and number from the ioctl command to enable
> > 32-bit user space compatibility on 64-bit kernel builds.
> >
> > Signed-off-by: Alessio Balsini <balsini@android.com>
> > ---
> > fs/fuse/dev.c | 29 ++++++++++++++++++-----------
> > include/uapi/linux/fuse.h | 3 ++-
> > 2 files changed, 20 insertions(+), 12 deletions(-)
> >
> > diff --git a/fs/fuse/dev.c b/fs/fuse/dev.c
> > index 588f8d1240aa..ff9f3b83f879 100644
> > --- a/fs/fuse/dev.c
> > +++ b/fs/fuse/dev.c
> > @@ -2233,37 +2233,44 @@ static int fuse_device_clone(struct fuse_conn *fc, struct file *new)
> > static long fuse_dev_ioctl(struct file *file, unsigned int cmd,
> > unsigned long arg)
> > {
> > - int err = -ENOTTY;
> > + int res;
> > + int oldfd;
> > + struct fuse_dev *fud = NULL;
> >
> > - if (cmd == FUSE_DEV_IOC_CLONE) {
> > - int oldfd;
> > + if (_IOC_TYPE(cmd) != FUSE_DEV_IOC_MAGIC)
> > + return -EINVAL;
>
> Why change ENOTTY to EINVAL?
>
> Thanks,
> MIklos
For the magic number mismatch I was thinking that EINVAL would have been
more appropriate, meaning: "this ioctl is definitely something this file
doesn't support". ENOTTY, could be more specific to the subset of
ioctls supported by the file, so I kept this in the default case of the
switch.
After counting the use of ENOTTY vs EINVAL for these _IOC_TYPE checks,
EINVALs were less than half ENOTTYs, so I'm totally fine with switching
back to ENOTTY in V13.
Thanks!
Alessio
next prev parent reply other threads:[~2021-03-01 12:27 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-25 15:30 [PATCH RESEND V12 0/8] fuse: Add support for passthrough read/write Alessio Balsini
2021-01-25 15:30 ` [PATCH RESEND V12 1/8] fs: Generic function to convert iocb to rw flags Alessio Balsini
2021-01-25 16:46 ` Alessio Balsini
2021-03-24 7:43 ` Rokudo Yan
2021-03-24 14:02 ` Alessio Balsini
2021-01-25 15:30 ` [PATCH RESEND V12 2/8] fuse: 32-bit user space ioctl compat for fuse device Alessio Balsini
[not found] ` <CAMAHBGzkfEd9-1u0iKXp65ReJQgUi_=4sMpmfkwEOaMp6Ux7pg@mail.gmail.com>
2021-01-27 13:40 ` Alessio Balsini
[not found] ` <CAMAHBGwpKW+30kNQ_Apt8A-FTmr94hBOzkT21cjEHHW+t7yUMQ@mail.gmail.com>
2021-01-28 14:15 ` Alessio Balsini
2021-02-05 9:54 ` Peng Tao
2021-03-16 18:57 ` Arnd Bergmann
2021-02-17 10:21 ` Miklos Szeredi
2021-03-01 12:26 ` Alessio Balsini [this message]
2021-03-16 18:53 ` Arnd Bergmann
2021-03-18 16:13 ` Alessio Balsini
2021-03-18 21:15 ` Arnd Bergmann
2021-03-19 15:21 ` Alessio Balsini
2021-01-25 15:30 ` [PATCH RESEND V12 3/8] fuse: Definitions and ioctl for passthrough Alessio Balsini
2021-02-17 13:41 ` Miklos Szeredi
2021-02-19 7:05 ` Peng Tao
2021-02-19 8:40 ` Miklos Szeredi
2021-03-01 17:05 ` Alessio Balsini
2022-09-08 15:36 ` Amir Goldstein
2022-09-09 19:07 ` Miklos Szeredi
2022-09-10 8:52 ` Amir Goldstein
2022-09-10 13:03 ` Bernd Schubert
2022-09-12 9:29 ` Miklos Szeredi
2022-09-12 12:29 ` Amir Goldstein
2022-09-12 13:03 ` Miklos Szeredi
2022-09-12 13:05 ` Miklos Szeredi
2022-09-12 13:26 ` Amir Goldstein
2022-09-12 14:22 ` Miklos Szeredi
2022-09-12 15:39 ` Amir Goldstein
2022-09-12 17:43 ` Hao Luo
2022-09-12 18:28 ` Overlayfs with writable lower layer Amir Goldstein
2022-09-13 18:26 ` Hao Luo
2022-09-13 18:54 ` Amir Goldstein
2022-09-13 20:33 ` Hao Luo
2022-09-14 3:46 ` Amir Goldstein
2022-09-14 18:00 ` Hao Luo
2022-09-14 19:23 ` Amir Goldstein
2022-09-14 19:33 ` Hao Luo
2022-09-15 10:54 ` Amir Goldstein
2023-05-12 19:37 ` [PATCH RESEND V12 3/8] fuse: Definitions and ioctl for passthrough Amir Goldstein
2023-05-15 7:29 ` Miklos Szeredi
2023-05-15 14:00 ` Amir Goldstein
2023-05-15 20:16 ` [fuse-devel] " Nikolaus Rath
2023-05-15 21:11 ` Bernd Schubert
2023-05-15 21:45 ` Paul Lawrence
2023-05-16 8:43 ` Miklos Szeredi
2023-05-16 10:16 ` Nikolaus Rath
2023-05-16 8:48 ` Amir Goldstein
2021-01-25 15:30 ` [PATCH RESEND V12 4/8] fuse: Passthrough initialization and release Alessio Balsini
2021-02-17 13:52 ` Miklos Szeredi
2021-05-05 12:21 ` Amir Goldstein
2021-05-17 11:36 ` Alessio Balsini
2021-05-17 13:21 ` Amir Goldstein
2021-01-25 15:30 ` [PATCH RESEND V12 5/8] fuse: Introduce synchronous read and write for passthrough Alessio Balsini
2021-02-17 14:00 ` Miklos Szeredi
2021-01-25 15:30 ` [PATCH RESEND V12 6/8] fuse: Handle asynchronous read and write in passthrough Alessio Balsini
2021-01-25 15:30 ` [PATCH RESEND V12 7/8] fuse: Use daemon creds in passthrough mode Alessio Balsini
2021-02-05 9:23 ` Peng Tao
2021-02-05 11:21 ` Alessio Balsini
2021-01-25 15:30 ` [PATCH RESEND V12 8/8] fuse: Introduce passthrough for mmap Alessio Balsini
2021-02-17 14:05 ` Miklos Szeredi
2021-04-01 11:24 ` Alessio Balsini
2021-11-18 18:31 ` [PATCH RESEND V12 0/8] fuse: Add support for passthrough read/write Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YDzdcnS1JJWboFYN@google.com \
--to=balsini@android.com \
--cc=akailash@google.com \
--cc=amir73il@gmail.com \
--cc=axboe@kernel.dk \
--cc=bergwolf@gmail.com \
--cc=duostefano93@gmail.com \
--cc=dvander@google.com \
--cc=fuse-devel@lists.sourceforge.net \
--cc=gscrivan@redhat.com \
--cc=jannh@google.com \
--cc=kernel-team@android.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maco@android.com \
--cc=miklos@szeredi.hu \
--cc=palmer@dabbelt.com \
--cc=paullawrence@google.com \
--cc=trapexit@spawn.link \
--cc=wu-yan@tcl.com \
--cc=zezeozue@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).