From: Michal Hocko <mhocko@suse.com>
To: Peter Enderborg <peter.enderborg@sony.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"Christian König" <christian.koenig@amd.com>,
"Alexey Dobriyan" <adobriyan@gmail.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Muchun Song" <songmuchun@bytedance.com>,
"Roman Gushchin" <guro@fb.com>,
"Shakeel Butt" <shakeelb@google.com>, NeilBrown <neilb@suse.de>,
"Sami Tolvanen" <samitolvanen@google.com>,
"Mike Rapoport" <rppt@kernel.org>,
linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org,
linaro-mm-sig@lists.linaro.org,
"Matthew Wilcox" <willy@infradead.org>
Subject: Re: [PATCH v4] dma-buf: Add DmaBufTotal counter in meminfo
Date: Mon, 19 Apr 2021 14:16:51 +0200 [thread overview]
Message-ID: <YH10s/7MjxBBsjVL@dhcp22.suse.cz> (raw)
In-Reply-To: <20210417104032.5521-1-peter.enderborg@sony.com>
On Sat 17-04-21 12:40:32, Peter Enderborg wrote:
> This adds a total used dma-buf memory. Details
> can be found in debugfs, however it is not for everyone
> and not always available. dma-buf are indirect allocated by
> userspace. So with this value we can monitor and detect
> userspace applications that have problems.
The changelog would benefit from more background on why this is needed,
and who is the primary consumer of that value.
I cannot really comment on the dma-buf internals but I have two remarks.
Documentation/filesystems/proc.rst needs an update with the counter
explanation and secondly is this information useful for OOM situations
analysis? If yes then show_mem should dump the value as well.
From the implementation point of view, is there any reason why this
hasn't used the existing global_node_page_state infrastructure?
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2021-04-19 12:16 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-17 10:40 [PATCH v4] dma-buf: Add DmaBufTotal counter in meminfo Peter Enderborg
2021-04-17 10:59 ` Christian König
2021-04-17 11:20 ` Peter.Enderborg
2021-04-17 11:54 ` Christian König
2021-04-17 12:13 ` Peter.Enderborg
2021-04-20 8:39 ` Daniel Vetter
2021-04-17 13:07 ` [External] " Muchun Song
2021-04-17 13:43 ` Peter.Enderborg
2021-04-17 14:21 ` Muchun Song
2021-04-17 15:03 ` Christian König
2021-04-19 12:16 ` Michal Hocko [this message]
2021-04-19 12:41 ` Peter.Enderborg
2021-04-19 15:00 ` Michal Hocko
2021-04-19 15:19 ` Peter.Enderborg
2021-04-19 15:44 ` Christian König
2021-04-19 16:11 ` Michal Hocko
2021-04-19 16:37 ` Christian König
2021-04-20 7:04 ` Michal Hocko
2021-04-20 7:20 ` Mike Rapoport
2021-04-20 7:47 ` Michal Hocko
2021-04-20 7:32 ` Christian König
2021-04-20 7:46 ` Michal Hocko
2021-04-20 8:00 ` Christian König
2021-04-20 8:28 ` Michal Hocko
2021-04-20 9:02 ` Peter.Enderborg
2021-04-20 9:12 ` Michal Hocko
2021-04-20 9:25 ` Peter.Enderborg
2021-04-20 11:04 ` Michal Hocko
2021-04-20 11:24 ` Peter.Enderborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YH10s/7MjxBBsjVL@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=guro@fb.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=neilb@suse.de \
--cc=peter.enderborg@sony.com \
--cc=rppt@kernel.org \
--cc=samitolvanen@google.com \
--cc=shakeelb@google.com \
--cc=songmuchun@bytedance.com \
--cc=sumit.semwal@linaro.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).