From: Michal Hocko <mhocko@suse.com>
To: Mike Rapoport <rppt@kernel.org>
Cc: Jonathan Corbet <corbet@lwn.net>,
Alexey Dobriyan <adobriyan@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Mike Rapoport <rppt@linux.ibm.com>,
linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] docs: proc.rst: meminfo: briefly describe gaps in memory accounting
Date: Tue, 20 Apr 2021 11:10:03 +0200 [thread overview]
Message-ID: <YH6aa8WJotXh8F+b@dhcp22.suse.cz> (raw)
In-Reply-To: <20210420085105.1156640-1-rppt@kernel.org>
On Tue 20-04-21 11:51:05, Mike Rapoport wrote:
> From: Mike Rapoport <rppt@linux.ibm.com>
Some trivial changelog would be better than nothing.
> Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>
But I do agree that this is a useful information to have in the
documentation. Having networking counters as an example is helpful as
well. I am not familiar with those myself much and I do remember there
is much to it than just sockstat. It would be great to consult this with
some networking expert and extend the documentation for that case which
tends to be quite common AFAIK.
Anyway this is already an improvement and a step into the right
direction.
Acked-by: Michal Hocko <mhocko@suse.com>
one nit below
> ---
> Documentation/filesystems/proc.rst | 11 +++++++++--
> 1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/filesystems/proc.rst b/Documentation/filesystems/proc.rst
> index 48fbfc336ebf..bf245151645b 100644
> --- a/Documentation/filesystems/proc.rst
> +++ b/Documentation/filesystems/proc.rst
> @@ -929,8 +929,15 @@ meminfo
> ~~~~~~~
>
> Provides information about distribution and utilization of memory. This
> -varies by architecture and compile options. The following is from a
> -16GB PIII, which has highmem enabled. You may not have all of these fields.
> +varies by architecture and compile options. Please note that is may happen
that it may happen
> +that the memory accounted here does not add up to the overall memory usage
> +and the difference for some workloads can be substantial. In many cases
> +there are other means to find out additional memory using subsystem
> +specific interfaces, for instance /proc/net/sockstat for networking
> +buffers.
> +
> +The following is from a 16GB PIII, which has highmem enabled.
> +You may not have all of these fields.
>
> ::
>
> --
> 2.29.2
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2021-04-20 9:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-20 8:51 [PATCH] docs: proc.rst: meminfo: briefly describe gaps in memory accounting Mike Rapoport
2021-04-20 9:10 ` Michal Hocko [this message]
2021-04-20 12:05 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YH6aa8WJotXh8F+b@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rppt@kernel.org \
--cc=rppt@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).