From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F7E9C43611 for ; Tue, 20 Apr 2021 12:05:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 97720613CE for ; Tue, 20 Apr 2021 12:05:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232298AbhDTMGH (ORCPT ); Tue, 20 Apr 2021 08:06:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:39466 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232229AbhDTMGH (ORCPT ); Tue, 20 Apr 2021 08:06:07 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 30048613BC; Tue, 20 Apr 2021 12:05:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1618920335; bh=ZiHFBNeowD0y96Ybd6GgNVVH0YPOMIokIMnSawx/I6M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ePV/HMcc9f+LS5cg6VomboUm0NIv23uuSuBV9Kyhx2lTKXBHLpSKoEhvIFhxDp+Yt Hh1r41ld6x7JhzOCD8/sbZU9XNF73DKBbhRWkNbrV7awJjFmJ4zylLyWdkf8mq/gT+ GVeQsVuNAHwoKnDMbcJ6d8svbs17BCkp/hZ1uy1U71jksL/vcG5/wVQiqWFUQ19qND Vq0cG5e2EJZBFjU+W7Y80NJN7Qdn+j5koh5J00yDa/THlbihu7HOAVbxMT3yotDoVQ GPD4Cgdxp2sBL0doAvtv5GEn7E/jT93K6HAX49T/0bBqhlE8ji8VcEheiAtYCfwdh5 oOir6xzbVz4Qw== Date: Tue, 20 Apr 2021 15:05:27 +0300 From: Mike Rapoport To: Michal Hocko Cc: Jonathan Corbet , Alexey Dobriyan , Andrew Morton , Mike Rapoport , linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] docs: proc.rst: meminfo: briefly describe gaps in memory accounting Message-ID: References: <20210420085105.1156640-1-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Tue, Apr 20, 2021 at 11:10:03AM +0200, Michal Hocko wrote: > On Tue 20-04-21 11:51:05, Mike Rapoport wrote: > > From: Mike Rapoport > > Some trivial changelog would be better than nothing. oh, sure. > > Signed-off-by: Mike Rapoport > > But I do agree that this is a useful information to have in the > documentation. Having networking counters as an example is helpful as > well. I am not familiar with those myself much and I do remember there > is much to it than just sockstat. It would be great to consult this with > some networking expert and extend the documentation for that case which > tends to be quite common AFAIK. I've found a citation from one of Eric Dumazet's emails [1], and used that instead: ... subsystem specific interfaces, for instance /proc/net/sockstat for TCP memory allocations [1] https://lore.kernel.org/lkml/CANn89iKprp7WYeZy4RRO5jHykprnSCcVBc7Tk14Ui_MA9OK7Fg@mail.gmail.com > Anyway this is already an improvement and a step into the right > direction. > > Acked-by: Michal Hocko > > one nit below > > --- > > Documentation/filesystems/proc.rst | 11 +++++++++-- > > 1 file changed, 9 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/filesystems/proc.rst b/Documentation/filesystems/proc.rst > > index 48fbfc336ebf..bf245151645b 100644 > > --- a/Documentation/filesystems/proc.rst > > +++ b/Documentation/filesystems/proc.rst > > @@ -929,8 +929,15 @@ meminfo > > ~~~~~~~ > > > > Provides information about distribution and utilization of memory. This > > -varies by architecture and compile options. The following is from a > > -16GB PIII, which has highmem enabled. You may not have all of these fields. > > +varies by architecture and compile options. Please note that is may happen > > that it may happen Right. > > +that the memory accounted here does not add up to the overall memory usage > > +and the difference for some workloads can be substantial. In many cases > > +there are other means to find out additional memory using subsystem > > +specific interfaces, for instance /proc/net/sockstat for networking > > +buffers. > > + > > +The following is from a 16GB PIII, which has highmem enabled. > > +You may not have all of these fields. > > > > :: > > > > -- > > 2.29.2 > > -- > Michal Hocko > SUSE Labs -- Sincerely yours, Mike.