From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 115E8C433B4 for ; Thu, 29 Apr 2021 10:08:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CB0FC61456 for ; Thu, 29 Apr 2021 10:08:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237774AbhD2KIe (ORCPT ); Thu, 29 Apr 2021 06:08:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:39348 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231543AbhD2KId (ORCPT ); Thu, 29 Apr 2021 06:08:33 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id BB819613FF; Thu, 29 Apr 2021 10:07:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1619690867; bh=VzjPKPK/cmePsjDFGEZjjuJ2zFB4L/Mth+h/t8LCH1c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=wGgbe3jsmGDhoEfb8w9Kr+NCAPqFsplN2yyPxceD5/2LvDGFHlnuLl+xlEtE/O3eq MONl+8NDYUdJzwqOuwuX1ZhOpzdpT2eNies1pm3rDAVKW9OAwS9k5EozFvjYsedlWd QjDyIlzas82eCSJyDwGvrDSOxzk/sKGjy0EdowDo= Date: Thu, 29 Apr 2021 12:07:44 +0200 From: Greg Kroah-Hartman To: "Arkadiusz Kozdra (Arusekk)" Cc: Linus Torvalds , Christoph Hellwig , Linux Kernel Mailing List , linux-fsdevel@vger.kernel.org, Alexey Dobriyan , Al Viro Subject: Re: [PATCH v2] proc: Use seq_read_iter for /proc/*/maps Message-ID: References: <20210429100508.18502-1-arek_koz@o2.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210429100508.18502-1-arek_koz@o2.pl> Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, Apr 29, 2021 at 12:05:08PM +0200, Arkadiusz Kozdra (Arusekk) wrote: > Since seq_read_iter looks mature enough to be used for /proc//maps, > re-allow applications to perform zero-copy data forwarding from it. > > Some executable-inspecting tools rely on patching entry point > instructions with minimal machine code that uses sendfile to read > /proc/self/maps to stdout. The sendfile call allows them to do it > faster and without excessive allocations. What programs do that today? You might want to list them here. > > This is inspired by the series by Cristoph Hellwig (linked). > > Changes since v1: > > only change proc_pid_maps_operations This should go below the --- line, like the documentation states. thanks, greg k-h