From: Rafael Aquini <aquini@redhat.com>
To: "Chu,Kaiping" <chukaiping@baidu.com>
Cc: "mcgrof@kernel.org" <mcgrof@kernel.org>,
"keescook@chromium.org" <keescook@chromium.org>,
"yzaikin@google.com" <yzaikin@google.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"vbabka@suse.cz" <vbabka@suse.cz>,
"nigupta@nvidia.com" <nigupta@nvidia.com>,
"bhe@redhat.com" <bhe@redhat.com>,
"khalid.aziz@oracle.com" <khalid.aziz@oracle.com>,
"iamjoonsoo.kim@lge.com" <iamjoonsoo.kim@lge.com>,
"mateusznosek0@gmail.com" <mateusznosek0@gmail.com>,
"sh_def@163.com" <sh_def@163.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: 答复: [PATCH v3] mm/compaction:let proactive compaction order configurable
Date: Thu, 29 Apr 2021 15:45:37 -0400 [thread overview]
Message-ID: <YIsM4UtV9UqKhsNB@optiplex-fbsd> (raw)
In-Reply-To: <f355248969f14e5897ad6dcfe3834297@baidu.com>
On Wed, Apr 28, 2021 at 01:17:40AM +0000, Chu,Kaiping wrote:
> Please see my answer inline.
>
> -----邮件原件-----
> 发件人: Rafael Aquini <aquini@redhat.com>
> 发送时间: 2021年4月26日 9:31
> 收件人: Chu,Kaiping <chukaiping@baidu.com>
> 抄送: mcgrof@kernel.org; keescook@chromium.org; yzaikin@google.com; akpm@linux-foundation.org; vbabka@suse.cz; nigupta@nvidia.com; bhe@redhat.com; khalid.aziz@oracle.com; iamjoonsoo.kim@lge.com; mateusznosek0@gmail.com; sh_def@163.com; linux-kernel@vger.kernel.org; linux-fsdevel@vger.kernel.org; linux-mm@kvack.org
> 主题: Re: [PATCH v3] mm/compaction:let proactive compaction order configurable
>
> On Sun, Apr 25, 2021 at 09:21:02AM +0800, chukaiping wrote:
> > Currently the proactive compaction order is fixed to
> > COMPACTION_HPAGE_ORDER(9), it's OK in most machines with lots of
> > normal 4KB memory, but it's too high for the machines with small
> > normal memory, for example the machines with most memory configured as
> > 1GB hugetlbfs huge pages. In these machines the max order of free
> > pages is often below 9, and it's always below 9 even with hard
> > compaction. This will lead to proactive compaction be triggered very
> > frequently. In these machines we only care about order of 3 or 4.
> > This patch export the oder to proc and let it configurable by user,
> > and the default value is still COMPACTION_HPAGE_ORDER.
> >
> > Signed-off-by: chukaiping <chukaiping@baidu.com>
> > Reported-by: kernel test robot <lkp@intel.com>
>
> Two minor nits on the commit log message:
> * there seems to be a whitespage missing in your short log:
> "... mm/compaction:let ..."
> --> I will fix it in next patch.
>
> * has the path really been reported by a test robot?
> --> Yes. There is a compile error in v1, I fixed it in v2.
>
So, no... the test robot should not be listed as Reported-by.
next prev parent reply other threads:[~2021-04-29 19:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-25 1:21 [PATCH v3] mm/compaction:let proactive compaction order configurable chukaiping
2021-04-26 1:15 ` David Rientjes
2021-04-26 1:29 ` 答复: " Chu,Kaiping
2021-04-26 1:48 ` David Rientjes
2021-04-28 1:38 ` 答复: " Chu,Kaiping
2021-05-06 21:27 ` Khalid Aziz
2021-05-11 7:48 ` 答复: " Chu,Kaiping
2021-05-11 15:00 ` Khalid Aziz
2021-04-26 1:31 ` Rafael Aquini
2021-04-28 1:17 ` 答复: " Chu,Kaiping
2021-04-29 19:45 ` Rafael Aquini [this message]
2021-05-06 1:08 ` 答复: " Chu,Kaiping
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YIsM4UtV9UqKhsNB@optiplex-fbsd \
--to=aquini@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=chukaiping@baidu.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=keescook@chromium.org \
--cc=khalid.aziz@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mateusznosek0@gmail.com \
--cc=mcgrof@kernel.org \
--cc=nigupta@nvidia.com \
--cc=sh_def@163.com \
--cc=vbabka@suse.cz \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).