From: Alexey Dobriyan <adobriyan@gmail.com>
To: youling257 <youling257@gmail.com>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 2/2] proc: convert everything to "struct proc_ops"
Date: Mon, 10 May 2021 20:13:32 +0300 [thread overview]
Message-ID: <YJlpvAXwpFtVlcy9@localhost.localdomain> (raw)
In-Reply-To: <20210510134238.4905-1-youling257@gmail.com>
On Mon, May 10, 2021 at 09:42:38PM +0800, youling257 wrote:
> Hi, my xt_qtaguid module need convert to "struct proc_ops",
> https://github.com/youling257/android-4.9/commit/a6e3cddcceb96eb3edeb0da0951399b75d4f8731
> https://github.com/youling257/android-4.9/commit/9eb92f5bcdcbc5b54d7dfe4b3050c8b9b8a17999
>
> static const struct proc_ops qtudev_proc_ops = {
> .proc_open = qtudev_open,
> .proc_release = qtudev_release,
> };
>
> static struct miscdevice qtu_device = {
> .minor = MISC_DYNAMIC_MINOR,
> .name = QTU_DEV_NAME,
> .fops = &qtudev_proc_ops,
> /* How sad it doesn't allow for defaults: .mode = S_IRUGO | S_IWUSR */
> };
>
> I have problem about ".fops = &qtudev_fops,", convert to ".fops = &qtudev_proc_ops," is right?
No! Those remain file_operations driving your device.
How is it supposed to work otherwise?
next prev parent reply other threads:[~2021-05-10 17:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-25 17:22 [PATCH 1/2] proc: decouple proc from VFS with "struct proc_ops" Alexey Dobriyan
[not found] ` <20191225172546.GB13378@avx2>
2019-12-31 23:01 ` [PATCH 2/2] proc: convert everything to " Andrew Morton
2020-01-06 15:17 ` Alexey Dobriyan
2021-05-10 13:42 ` youling257
2021-05-10 17:13 ` Alexey Dobriyan [this message]
2021-05-10 18:39 ` youling 257
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJlpvAXwpFtVlcy9@localhost.localdomain \
--to=adobriyan@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=youling257@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).