From: Johannes Weiner <hannes@cmpxchg.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Dave Chinner <david@fromorbit.com>, Roman Gushchin <guro@fb.com>,
Tejun Heo <tj@kernel.org>,
linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH 4/4] vfs: keep inodes with page cache off the inode shrinker LRU
Date: Fri, 18 Jun 2021 13:09:30 -0400 [thread overview]
Message-ID: <YMzTSteDJkZkVziO@cmpxchg.org> (raw)
In-Reply-To: <20210616183043.cdd36c5ca6bee8614c609a90@linux-foundation.org>
On Wed, Jun 16, 2021 at 06:30:43PM -0700, Andrew Morton wrote:
> On Wed, 16 Jun 2021 00:54:15 -0400 Johannes Weiner <hannes@cmpxchg.org> wrote:
> > On Wed, Jun 16, 2021 at 11:20:08AM +1000, Dave Chinner wrote:
> > > On Tue, Jun 15, 2021 at 02:50:09PM -0400, Johannes Weiner wrote:
> > > > On Tue, Jun 15, 2021 at 04:26:40PM +1000, Dave Chinner wrote:
> > > > > On Mon, Jun 14, 2021 at 05:19:04PM -0400, Johannes Weiner wrote:
> > > > > > @@ -1123,6 +1125,9 @@ static int __remove_mapping(struct address_space *mapping, struct page *page,
> > > > > > shadow = workingset_eviction(page, target_memcg);
> > > > > > __delete_from_page_cache(page, shadow);
> > > > > > xa_unlock_irq(&mapping->i_pages);
> > > > > > + if (mapping_shrinkable(mapping))
> > > > > > + inode_add_lru(mapping->host);
> > > > > > + spin_unlock(&mapping->host->i_lock);
> > > > > >
> > > > >
> > > > > No. Inode locks have absolutely no place serialising core vmscan
> > > > > algorithms.
> > > >
> > > > What if, and hear me out on this one, core vmscan algorithms change
> > > > the state of the inode?
> > >
> > > Then the core vmscan algorithm has a layering violation.
> >
> > You're just playing a word game here.
>
> Don't think so. David is quite correct in saying that vmscan shouldn't
> mess with inode state unless it's via address_space_operations?
It seemed to me the complaint was more about vmscan propagating this
state into the inode in general - effecting fs inode acquisitions and
LRU manipulations from the page reclaim callstack - regardless of
whether they are open-coded or indirect through API functions?
Since I mentioned better encapsulation but received no response...
next prev parent reply other threads:[~2021-06-18 17:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-14 21:19 [PATCH 1/4] mm: remove irqsave/restore locking from contexts with irqs enabled Johannes Weiner
2021-06-14 21:19 ` [PATCH 2/4] fs: drop_caches: fix skipping over shadow cache inodes Johannes Weiner
2021-06-14 22:31 ` Roman Gushchin
2021-06-14 21:19 ` [PATCH 3/4] fs: inode: count invalidated shadow pages in pginodesteal Johannes Weiner
2021-06-14 21:19 ` [PATCH 4/4] vfs: keep inodes with page cache off the inode shrinker LRU Johannes Weiner
2021-06-14 21:59 ` Andrew Morton
2021-06-14 22:41 ` Johannes Weiner
2021-06-15 6:26 ` Dave Chinner
2021-06-15 18:50 ` Johannes Weiner
2021-06-16 1:20 ` Dave Chinner
2021-06-16 4:54 ` Johannes Weiner
2021-06-17 0:49 ` Dave Chinner
2021-06-18 16:45 ` Johannes Weiner
2021-06-28 18:58 ` Johannes Weiner
2021-06-17 1:30 ` Andrew Morton
2021-06-18 17:09 ` Johannes Weiner [this message]
2021-06-28 17:12 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMzTSteDJkZkVziO@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linux-foundation.org \
--cc=david@fromorbit.com \
--cc=guro@fb.com \
--cc=kernel-team@fb.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).