From: Matthew Wilcox <willy@infradead.org>
To: David Howells <dhowells@redhat.com>
Cc: linux-cachefs@redhat.com, linux-afs@lists.infradead.org,
Jeff Layton <jlayton@kernel.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] afs: Handle len being extending over page end in write_begin/write_end
Date: Mon, 21 Jun 2021 15:32:44 +0100 [thread overview]
Message-ID: <YNCjDGXGfewvl8E0@casper.infradead.org> (raw)
In-Reply-To: <162391824293.1173366.15452474691364794223.stgit@warthog.procyon.org.uk>
On Thu, Jun 17, 2021 at 09:24:02AM +0100, David Howells wrote:
> With transparent huge pages, in the future, write_begin() and write_end()
> may be passed a length parameter that, in combination with the offset into
> the page, exceeds the length of that page. This allows
> grab_cache_page_write_begin() to better choose the size of THP to allocate.
While this is all true, it's really not necessary at this point in time.
That change will come with a conversion of these functions to work with
folios and basically every line you change here will change again.
next prev parent reply other threads:[~2021-06-21 14:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-17 8:23 [PATCH v2 0/3] netfs, afs: Fix netfs_write_begin and THP handling David Howells
2021-06-17 8:24 ` [PATCH v2 1/3] afs: Handle len being extending over page end in write_begin/write_end David Howells
2021-06-21 14:32 ` Matthew Wilcox [this message]
2021-06-17 8:24 ` [PATCH v2 2/3] afs: Fix afs_write_end() to handle short writes David Howells
2021-06-21 14:36 ` Matthew Wilcox
2021-06-17 8:24 ` [PATCH v2 3/3] netfs: fix test for whether we can skip read when writing beyond EOF David Howells
2021-06-21 14:50 ` Matthew Wilcox
2021-06-18 3:46 ` [PATCH v2 0/3] netfs, afs: Fix netfs_write_begin and THP handling Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNCjDGXGfewvl8E0@casper.infradead.org \
--to=willy@infradead.org \
--cc=dhowells@redhat.com \
--cc=jlayton@kernel.org \
--cc=linux-afs@lists.infradead.org \
--cc=linux-cachefs@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).