From: Al Viro <viro@zeniv.linux.org.uk>
To: Christoph Hellwig <hch@lst.de>
Cc: Vivek Goyal <vgoyal@redhat.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
virtio-fs@redhat.com
Subject: Re: [PATCH 1/2] init: split get_fs_names
Date: Mon, 21 Jun 2021 14:59:05 +0000 [thread overview]
Message-ID: <YNCpOaNHRA9jEOpM@zeniv-ca.linux.org.uk> (raw)
In-Reply-To: <20210621145309.GA4995@lst.de>
On Mon, Jun 21, 2021 at 04:53:09PM +0200, Christoph Hellwig wrote:
> On Mon, Jun 21, 2021 at 02:46:37PM +0000, Al Viro wrote:
> > TBH, I would rather take that one into fs/filesystems.c. Rationale:
> > get_filesystem_list(), for all its resemblance to /proc/filesystems
> > contents, is used only by init/*.c and it's not a big deal to make
> > it
>
> Yeah, unwinding this mess actually is a good idea. I didn't really
> look outside of do_mounts.c, but once doing that it becomes completely
> obvious.
>
> > int __init get_filesystem_list(char *buf, bool is_dev)
>
> As-is we don't even really need the is_dev argument, as the only
> callers wants block device file systems anyway.
*nod*
> In fact it would
> much rather have a cursor based iteration so that we can skip the
> allocation, but that is probaby overengineering the problem.
Very much so.
Sigh... I really wish we had more uniform syntax, though -
e.g. root=nfs(<options>) or root=xfs(sdb11,noatime), etc.
Oh, well...
next prev parent reply other threads:[~2021-06-21 14:59 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-21 6:26 support booting of arbitrary non-blockdevice file systems v2 Christoph Hellwig
2021-06-21 6:26 ` [PATCH 1/2] init: split get_fs_names Christoph Hellwig
2021-06-21 14:46 ` Al Viro
2021-06-21 14:51 ` Al Viro
2021-06-21 14:53 ` Christoph Hellwig
2021-06-21 14:59 ` Al Viro [this message]
2021-06-21 15:09 ` Matthew Wilcox
2021-06-21 15:22 ` Christoph Hellwig
2021-06-21 6:26 ` [PATCH 2/2] init: allow mounting arbitrary non-blockdevice filesystems as root Christoph Hellwig
2021-06-21 13:31 ` [Virtio-fs] support booting of arbitrary non-blockdevice file systems v2 Stefan Hajnoczi
2021-06-21 14:35 ` Vivek Goyal
2021-06-22 8:12 ` [PATCH 3/2] fs: simplify get_filesystem_list / get_all_fs_names Christoph Hellwig
2021-06-22 8:36 ` [Virtio-fs] " Stefan Hajnoczi
2021-06-29 20:50 ` Vivek Goyal
2021-06-30 5:36 ` Christoph Hellwig
2021-06-30 17:33 ` Vivek Goyal
2021-07-07 21:04 ` Vivek Goyal
2021-07-07 21:06 ` Vivek Goyal
2021-07-08 12:59 ` Vivek Goyal
2021-07-12 18:21 ` Vivek Goyal
2021-07-13 5:40 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2021-06-17 15:36 support booting of arbitrary non-blockdevice file systems Christoph Hellwig
2021-06-17 15:36 ` [PATCH 1/2] init: split get_fs_names Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNCpOaNHRA9jEOpM@zeniv-ca.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vgoyal@redhat.com \
--cc=virtio-fs@redhat.com \
--subject='Re: [PATCH 1/2] init: split get_fs_names' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).