From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89761C48BE5 for ; Wed, 23 Jun 2021 09:30:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 72E2A611AD for ; Wed, 23 Jun 2021 09:30:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230053AbhFWJc5 (ORCPT ); Wed, 23 Jun 2021 05:32:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48062 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230004AbhFWJcy (ORCPT ); Wed, 23 Jun 2021 05:32:54 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A3295C061574; Wed, 23 Jun 2021 02:30:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=NU7eentD395rdHeDZnxtO6t94JfTEFM9vaCy6vjeiLE=; b=TpyRcfJAQcJETLpJhvymhsCd9K lmpYZgQoE+WXW7WlWJSdxAyarKrD/3Mh3ZqcJmy2ApK1wEwpJ4uYUYNpmc8fJxlpw7DyQMpis76YI BH5hnix8ZqRL/sL1wtXPr/CKDmbTd7vjwv2Hzm52mlcNX6YS+u4m74YbmPd4Sftpe8vReBEZJQvzt 3fQ353Kpzakay+T+ZTY18CZdQZzV318cCqwAGaE/d5dldyX0bIawT+DVdAU187PMSqLo6wB/du6uH oWPmXJfHPeH77er7UQ3jFafrVNpMLU1AaX5cyJbCHmDynATXHZnyh92L8LF1pe297SFEjGbd48HkZ KRXJtKuQ==; Received: from 089144193030.atnat0002.highway.a1.net ([89.144.193.30] helo=localhost) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvzCE-00FGQZ-TG; Wed, 23 Jun 2021 09:29:27 +0000 Date: Wed, 23 Jun 2021 11:27:12 +0200 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 27/46] mm/writeback: Add __folio_mark_dirty() Message-ID: References: <20210622121551.3398730-1-willy@infradead.org> <20210622121551.3398730-28-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210622121551.3398730-28-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Tue, Jun 22, 2021 at 01:15:32PM +0100, Matthew Wilcox (Oracle) wrote: > Turn __set_page_dirty() into a wrapper around __folio_mark_dirty() (which > can directly cast from page to folio because we know that set_page_dirty() > calls filesystems with the head page). Convert account_page_dirtied() > into folio_account_dirtied() and account the number of pages in the folio. Is it really worth micro-optimizing a transitional function like that? I'd rather eat the overhead of the compound_page() call over adding hacky casts like this.