From: Christoph Hellwig <hch@infradead.org>
To: Anton Suvorov <warwish@yandex-team.ru>
Cc: willy@infradead.org, dmtrmonakhov@yandex-team.ru,
linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk
Subject: Re: [PATCH v2 05/10] block: reduce stack footprint dealing with block device names
Date: Wed, 23 Jun 2021 08:45:02 +0100 [thread overview]
Message-ID: <YNLmfsrS6RIFBX/n@infradead.org> (raw)
In-Reply-To: <20210622174424.136960-6-warwish@yandex-team.ru>
On Tue, Jun 22, 2021 at 08:44:19PM +0300, Anton Suvorov wrote:
> Stack usage reduced (measured with allyesconfig):
Not just stack footprint, but also a whole lot cleaner code in general.
> - bdevname(state->bdev, b), blk);
> + pr_err("Dev %pg: unable to read RDB block %d\n", state->bdev, blk);
> - bdevname(state->bdev, b), blk);
> + pr_err("Dev %pg: RDB in block %d has bad checksum\n", state->bdev, blk);
> - pr_err("Dev %s: unable to read partition block %d\n",
> - bdevname(state->bdev, b), blk);
> + pr_err("Dev %pg: unable to read partition block %d\n", state->bdev, blk);
[...]
Please keep the non-format string arguments on separate lines instead
of creating unreadable lines.
next prev parent reply other threads:[~2021-06-23 7:45 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-02 15:28 [PATCH 00/10] reduce stack footprint printing bdev names Anton Suvorov
2021-06-02 15:28 ` [PATCH 01/10] drbd: reduce stack footprint in drbd_report_io_error() Anton Suvorov
2021-06-02 15:28 ` [PATCH 02/10] dax: reduce stack footprint dealing with block device names Anton Suvorov
2021-06-02 17:18 ` Matthew Wilcox
2021-06-22 17:44 ` [PATCH v2 00/10] reduce stack footprint printing bdev names Anton Suvorov
2021-06-22 17:44 ` [PATCH v2 01/10] drbd: reduce stack footprint in drbd_report_io_error() Anton Suvorov
2021-06-22 17:44 ` [PATCH v2 02/10] dax: reduce stack footprint dealing with block device names Anton Suvorov
2021-06-22 17:44 ` [PATCH v2 03/10] raid-md: " Anton Suvorov
2021-06-23 8:26 ` Guoqing Jiang
2021-06-22 17:44 ` [PATCH v2 04/10] dm: " Anton Suvorov
2021-06-22 17:44 ` [PATCH v2 05/10] block: " Anton Suvorov
2021-06-23 7:45 ` Christoph Hellwig [this message]
2021-06-22 17:44 ` [PATCH v2 06/10] target: reduce stack footprint in iblock_show_configfs_dev_params() Anton Suvorov
2021-06-22 17:44 ` [PATCH v2 07/10] vfs: reduce stack footprint in __blkdev_put() Anton Suvorov
2021-06-22 17:44 ` [PATCH v2 08/10] ext4: reduce stack footprint in ext4_end_bio() Anton Suvorov
2021-06-22 17:44 ` [PATCH v2 09/10] security: reduce stack footprint in loadpin_read_file() Anton Suvorov
2021-06-22 17:45 ` [PATCH v2 10/10] block: remove unused symbol bio_devname() Anton Suvorov
2021-06-02 15:28 ` [PATCH 03/10] raid-md: reduce stack footprint dealing with block device names Anton Suvorov
2021-06-02 15:28 ` [PATCH 04/10] dm: " Anton Suvorov
2021-06-23 20:20 ` Mike Snitzer
2021-06-02 15:28 ` [PATCH 05/10] block: " Anton Suvorov
2021-06-02 15:28 ` [PATCH 06/10] target: reduce stack footprint in iblock_show_configfs_dev_params() Anton Suvorov
2021-06-02 15:29 ` [PATCH 07/10] vfs: reduce stack footprint in __blkdev_put() Anton Suvorov
2021-06-02 15:29 ` [PATCH 08/10] ext4: reduce stack footprint in ext4_end_bio() Anton Suvorov
2021-06-02 15:29 ` [PATCH 09/10] security: reduce stack footprint in loadpin_read_file() Anton Suvorov
2021-06-02 15:29 ` [PATCH 10/10] block: remove unused symbol bio_devname() Anton Suvorov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNLmfsrS6RIFBX/n@infradead.org \
--to=hch@infradead.org \
--cc=dmtrmonakhov@yandex-team.ru \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=warwish@yandex-team.ru \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).