From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C82C4C48BC2 for ; Wed, 23 Jun 2021 11:31:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AA20B6102A for ; Wed, 23 Jun 2021 11:31:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230509AbhFWLeA (ORCPT ); Wed, 23 Jun 2021 07:34:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47172 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230138AbhFWLeA (ORCPT ); Wed, 23 Jun 2021 07:34:00 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1169CC061756; Wed, 23 Jun 2021 04:31:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=nr51oxoXOse8+0HctYzGgI91ZnJJczBmgfx3fw83CwY=; b=U9piStg8JkBL5HYU3anvGC5AxX +MAK7WmSIDRkJv9p/7UV4vy/U4HFxkjSKjdC65dgCtGadzw7HDOMCgc/TsC526zBlwQ8jVFU3mWTF SK+5VaONZkuWHA9aqZlJ0/pTIUKMXxNgJ85JoIZuHRim/6j4oQGLX4Mcrr4IRbocblAuI2s8X4JDf UR56jcU7AvQK8K1XXjW7vSu3gnFBwp6pH5DOlATd4bGwzdPGMtqVZLA93bB0zWhjmuo7KvCPxkUK1 3GZwohCBrkR5yv/HoC7Vta7FKeeHF1Vt3h3D3SRVPTuwXIl/bbS0ICwWHiQznUYUvlMq+isJLlB/4 y2n2w7kw==; Received: from [2001:4bb8:188:3e21:6594:49:139:2b3f] (helo=localhost) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1lw154-00FMfW-NV; Wed, 23 Jun 2021 11:30:17 +0000 Date: Wed, 23 Jun 2021 13:30:04 +0200 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 43/46] mm/filemap: Add filemap_add_folio Message-ID: References: <20210622121551.3398730-1-willy@infradead.org> <20210622121551.3398730-44-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210622121551.3398730-44-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Tue, Jun 22, 2021 at 01:15:48PM +0100, Matthew Wilcox (Oracle) wrote: > Pages being added to the page cache should already be folios, so > just cast the page to a folio in the add_to_page_cache_lru() wrapper. > Saves 96 bytes of text. modulo the casting: Reviewed-by: Christoph Hellwig