From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E721DC49EA5 for ; Thu, 24 Jun 2021 14:36:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CD890613EC for ; Thu, 24 Jun 2021 14:36:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232088AbhFXOiq (ORCPT ); Thu, 24 Jun 2021 10:38:46 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:53484 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S230170AbhFXOim (ORCPT ); Thu, 24 Jun 2021 10:38:42 -0400 Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 15OEZOhp006025 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 24 Jun 2021 10:35:25 -0400 Received: by cwcc.thunk.org (Postfix, from userid 15806) id D389415C3CD7; Thu, 24 Jun 2021 10:35:24 -0400 (EDT) Date: Thu, 24 Jun 2021 10:35:24 -0400 From: "Theodore Ts'o" To: Zhang Yi Cc: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, jack@suse.cz, adilger.kernel@dilger.ca, david@fromorbit.com, hch@infradead.org Subject: Re: [RFC PATCH v4 2/8] jbd2: ensure abort the journal if detect IO error when writing original buffer back Message-ID: References: <20210610112440.3438139-1-yi.zhang@huawei.com> <20210610112440.3438139-3-yi.zhang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210610112440.3438139-3-yi.zhang@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, Jun 10, 2021 at 07:24:34PM +0800, Zhang Yi wrote: > Although we merged c044f3d8360 ("jbd2: abort journal if free a async > write error metadata buffer"), there is a race between > jbd2_journal_try_to_free_buffers() and jbd2_journal_destroy(), so the > jbd2_log_do_checkpoint() may still fail to detect the buffer write > io error flag which may lead to filesystem inconsistency. > > jbd2_journal_try_to_free_buffers() ext4_put_super() > jbd2_journal_destroy() > __jbd2_journal_remove_checkpoint() > detect buffer write error jbd2_log_do_checkpoint() > jbd2_cleanup_journal_tail() > <--- lead to inconsistency > jbd2_journal_abort() > > Fix this issue by introducing a new atomic flag which only have one > JBD2_CHECKPOINT_IO_ERROR bit now, and set it in > __jbd2_journal_remove_checkpoint() when freeing a checkpoint buffer > which has write_io_error flag. Then jbd2_journal_destroy() will detect > this mark and abort the journal to prevent updating log tail. > > Signed-off-by: Zhang Yi > Reviewed-by: Jan Kara Applied, thanks. - Ted