From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F40F4C49EA6 for ; Thu, 24 Jun 2021 23:50:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D802B613AB for ; Thu, 24 Jun 2021 23:50:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232300AbhFXXxI (ORCPT ); Thu, 24 Jun 2021 19:53:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229521AbhFXXxI (ORCPT ); Thu, 24 Jun 2021 19:53:08 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F65BC061574; Thu, 24 Jun 2021 16:50:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=QrDKKmi2jhhfzOeBzeGjVF68+wOp3Rw/4GYCckMy6O0=; b=EfowUAHjP6rvRkIOaO+mR4InfD GejD3d/O+OyWxQPJMl2kq/YpZoKjLm1p0OBREnlf3p1ZTuYTey5653em5WZyoO5nTe3Z8s4j1C6A0 IHyyxgR29GT5bL2/6o5mNB0RLlpOyjLgE4erh834BsEOLXfWNsMwCyVnSsaVS5ru+ndWnFkNNcJL0 iOPa5zzpnqhvMsXS40UQ443a0enMggojGVMuhJ+aX5wsnkcYATa0Rmu3DXlNAxeo181LjD3ASdSeH nDnFvpDocBIBgzRJdBpZcR/GSRLcZt9Kb/zKd6uyo1oPfBuZORVpY7DsJzT2q8qzlgwIRw/wwaGDv QsZS3h9g==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwZ70-00H7b7-Td; Thu, 24 Jun 2021 23:50:27 +0000 Date: Fri, 25 Jun 2021 00:50:22 +0100 From: Matthew Wilcox To: Christoph Hellwig Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 38/46] mm: Add folio_evictable() Message-ID: References: <20210622121551.3398730-1-willy@infradead.org> <20210622121551.3398730-39-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, Jun 23, 2021 at 11:54:06AM +0200, Christoph Hellwig wrote: > > + * Reasons folio might not be evictable: > > + * 1. page's mapping marked unevictable > > + * 2. page is part of an mlocked VMA > > s/page/folio/? Thanks. * Reasons folio might not be evictable: * 1. folio's mapping marked unevictable * 2. One of the pages in the folio is part of an mlocked VMA > Otherwise looks good: > > Reviewed-by: Christoph Hellwig