From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07BAEC2B9F4 for ; Mon, 28 Jun 2021 06:19:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D3F19619F1 for ; Mon, 28 Jun 2021 06:19:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231698AbhF1GVv (ORCPT ); Mon, 28 Jun 2021 02:21:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39690 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229778AbhF1GVv (ORCPT ); Mon, 28 Jun 2021 02:21:51 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D984C061574; Sun, 27 Jun 2021 23:19:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=xMH8quXQ1KpWPHQ/uSY3qrmdHTNL0PryLpfY1lJx2As=; b=iWmFPkkIzsRjeKkXUXSj1vkwO3 Opc9hXPZSxrq59VAAIL4MKfAvvLICTMq7YzIdJfPyoLMiicmO9d6mLrbmRtUxQ9gvR78JX8LRpZ5d 2YW/N99ZjFSL4HWkTuCqa5fTgpbFWhlQQgtbZU9ZYidjkCoFJDT/zR+CujqyWCfvzANW1izB7AcRm c/D0742mwQsHmcl7juN3pVd2PsNkQDIkRcmPnMa0+B19cqqB1NbojPjOzsW+ql6Lvo109Sz+V1ph+ zXB35fnSX4wO2LXWPh+pkqj9WzrNUupNSDr/ptvFj9BrqAWapjEcMZdVBOg5QzH6GvSEe3DmsvklF A9R904fw==; Received: from hch by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1lxkaw-002eLV-Ka; Mon, 28 Jun 2021 06:18:18 +0000 Date: Mon, 28 Jun 2021 07:18:10 +0100 From: Christoph Hellwig To: Matthew Wilcox Cc: Christoph Hellwig , akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 01/46] mm: Add folio_to_pfn() Message-ID: References: <20210622121551.3398730-1-willy@infradead.org> <20210622121551.3398730-2-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, Jun 24, 2021 at 04:12:05PM +0100, Matthew Wilcox wrote: > On Wed, Jun 23, 2021 at 08:49:55AM +0100, Christoph Hellwig wrote: > > On Tue, Jun 22, 2021 at 01:15:06PM +0100, Matthew Wilcox (Oracle) wrote: > > > The pfn of a folio is the pfn of its head page. > > > > > > Signed-off-by: Matthew Wilcox (Oracle) > > > > Maybe add a kerneldoc comment stating that? > > /** > * folio_to_pfn - Return the Page Frame Number of a folio. > * @folio: The folio. > * > * A folio may contain multiple pages. The pages have consecutive > * Page Frame Numbers. > * > * Return: The Page Frame Number of the first page in the folio. > */ Looks fine.