From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6149FC2B9F4 for ; Mon, 28 Jun 2021 06:22:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3B74A619B6 for ; Mon, 28 Jun 2021 06:22:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230148AbhF1GYx (ORCPT ); Mon, 28 Jun 2021 02:24:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40360 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229778AbhF1GYx (ORCPT ); Mon, 28 Jun 2021 02:24:53 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F6C8C061574; Sun, 27 Jun 2021 23:22:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=VSsqQEp1WXFodl078mceGS44th1ZKo/aF0XDPZZ2Tcg=; b=QdwZdGg3j+z6Dm6AzMGqoPOdKB STViCsfUG5LlsQiTEzIiB1KCSidtIA35CI2nNppfCeJqj2nxuStGwikeyKajGSCthOxCArEZqJ1zz IqGb2hoESRLOxS+YjPyKB+iUSJpmtlolyX9LRkrFrcjpNlliznJiTE0eYZAF8WcA9o/Kwh8JwIvMR MnpRGINmpt9mNyMaOTSsENwsSY1Ukg1R/5p3Og5GJ+j3yZI744XRg7sKKPhfPMHV6JvnVBUzhLzbK jDWjwTehNGInf5Rbu2FL4Ez6V8ZSUtOtcl+J30WILnnK+9IlByQswZeoweluclC06LIePV22520aA z/Ev1mBg==; Received: from hch by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1lxkdh-002eSv-4o; Mon, 28 Jun 2021 06:21:11 +0000 Date: Mon, 28 Jun 2021 07:21:01 +0100 From: Christoph Hellwig To: Matthew Wilcox Cc: Christoph Hellwig , akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 05/46] mm: Add arch_make_folio_accessible() Message-ID: References: <20210622121551.3398730-1-willy@infradead.org> <20210622121551.3398730-6-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, Jun 24, 2021 at 04:57:29PM +0100, Matthew Wilcox wrote: > On Wed, Jun 23, 2021 at 10:00:37AM +0200, Christoph Hellwig wrote: > > On Tue, Jun 22, 2021 at 01:15:10PM +0100, Matthew Wilcox (Oracle) wrote: > > > As a default implementation, call arch_make_page_accessible n times. > > > If an architecture can do better, it can override this. > > > > > > Also move the default implementation of arch_make_page_accessible() > > > from gfp.h to mm.h. > > > > Can we wait with introducing arch hooks until we have an actual user > > lined up? > > This one gets used in __folio_end_writeback() which is patch 24 in this > series. With arch hook I mean the ifdef to allow the architeture to override the folio function. Same for the previous patch, btw.