From: Christoph Hellwig <hch@infradead.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: Andreas Gr?nbacher <andreas.gruenbacher@gmail.com>,
Christoph Hellwig <hch@infradead.org>,
linux-erofs@lists.ozlabs.org,
Linux FS-devel Mailing List <linux-fsdevel@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
"Darrick J. Wong" <djwong@kernel.org>, Chao Yu <chao@kernel.org>,
Liu Bo <bo.liu@linux.alibaba.com>,
Joseph Qi <joseph.qi@linux.alibaba.com>,
Liu Jiang <gerry@linux.alibaba.com>
Subject: Re: [PATCH 1/2] iomap: support tail packing inline read
Date: Mon, 19 Jul 2021 12:19:34 +0100 [thread overview]
Message-ID: <YPVfxn6/oCPBZpKu@infradead.org> (raw)
In-Reply-To: <YPMkKfegS+9KzEhK@casper.infradead.org>
On Sat, Jul 17, 2021 at 07:40:41PM +0100, Matthew Wilcox wrote:
> Well, either sense of a WARN_ON is wrong.
>
> For a file which is PAGE_SIZE + 3 bytes in size, to_iomap_page() will
> be NULL. For a file which is PAGE_SIZE/2 + 3 bytes in size,
> to_iomap_page() will not be NULL. (assuming the block size is <=
> PAGE_SIZE / 2).
>
> I think we need a prep patch that looks something like this:
Something like this is where we should eventually end up, but it
also affects the read from disk case so we need to be careful.
next prev parent reply other threads:[~2021-07-19 11:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-16 5:07 [PATCH 0/2] erofs: iomap support for tailpacking cases Gao Xiang
2021-07-16 5:07 ` [PATCH 1/2] iomap: support tail packing inline read Gao Xiang
2021-07-16 9:19 ` Christoph Hellwig
2021-07-16 9:46 ` Gao Xiang
2021-07-16 13:47 ` Matthew Wilcox
2021-07-16 14:38 ` Matthew Wilcox
2021-07-16 13:02 ` Matthew Wilcox
2021-07-16 13:56 ` Gao Xiang
2021-07-16 14:44 ` Matthew Wilcox
2021-07-16 15:03 ` Gao Xiang
2021-07-16 15:53 ` Andreas Grünbacher
2021-07-17 13:38 ` Gao Xiang
2021-07-17 15:01 ` Matthew Wilcox
2021-07-17 15:15 ` Gao Xiang
2021-07-17 18:40 ` Matthew Wilcox
2021-07-19 11:19 ` Christoph Hellwig [this message]
2021-07-19 13:45 ` Gao Xiang
2021-07-19 11:15 ` Christoph Hellwig
2021-07-19 13:31 ` Gao Xiang
2021-07-16 5:07 ` [PATCH 2/2] erofs: convert all uncompressed cases to iomap Gao Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YPVfxn6/oCPBZpKu@infradead.org \
--to=hch@infradead.org \
--cc=andreas.gruenbacher@gmail.com \
--cc=bo.liu@linux.alibaba.com \
--cc=chao@kernel.org \
--cc=djwong@kernel.org \
--cc=gerry@linux.alibaba.com \
--cc=joseph.qi@linux.alibaba.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).