linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH] iomap: pass writeback errors to the mapping
Date: Thu, 5 Aug 2021 23:12:39 +0100	[thread overview]
Message-ID: <YQxiVxSWWwZwoqbZ@casper.infradead.org> (raw)
In-Reply-To: <20210805213154.GZ3601443@magnolia>

On Thu, Aug 05, 2021 at 02:31:54PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
> 
> Modern-day mapping_set_error has the ability to squash the usual
> negative error code into something appropriate for long-term storage in
> a struct address_space -- ENOSPC becomes AS_ENOSPC, and everything else
> becomes EIO.  iomap squashes /everything/ to EIO, just as XFS did before
> that, but this doesn't make sense.
> 
> Fix this by making it so that we can pass ENOSPC to userspace when
> writeback fails due to space problems.
> 
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>

I could have sworn I sent this patch in earlier.  Anyway,

Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>

  reply	other threads:[~2021-08-05 22:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-05 21:31 [PATCH] iomap: pass writeback errors to the mapping Darrick J. Wong
2021-08-05 22:12 ` Matthew Wilcox [this message]
2021-08-09 23:35   ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YQxiVxSWWwZwoqbZ@casper.infradead.org \
    --to=willy@infradead.org \
    --cc=djwong@kernel.org \
    --cc=hch@infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).