From: Matthew Wilcox <willy@infradead.org>
To: Roberto Bergantinos Corpas <rbergant@redhat.com>
Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] vfs: parse sloppy mount option in correct order
Date: Thu, 26 Aug 2021 13:46:46 +0100 [thread overview]
Message-ID: <YSeNNnNBW7ceLuh+@casper.infradead.org> (raw)
In-Reply-To: <20210721113057.993344-1-rbergant@redhat.com>
On Wed, Jul 21, 2021 at 01:30:57PM +0200, Roberto Bergantinos Corpas wrote:
> With addition of fs_context support, options string is parsed
> sequentially, if 'sloppy' option is not leftmost one, we may
> return ENOPARAM to userland if a non-valid option preceeds sloopy
> and mount will fail :
>
> host# mount -o quota,sloppy 172.23.1.225:/share /mnt
> mount.nfs: an incorrect mount option was specified
> host# mount -o sloppy,quota 172.23.1.225:/share /mnt
It isn't clear to me that this is incorrect behaviour. Perhaps the user
actually wants the options to the left parsed strictly and the options
to the right parsed sloppily?
next prev parent reply other threads:[~2021-08-26 12:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-21 11:30 [PATCH] vfs: parse sloppy mount option in correct order Roberto Bergantinos Corpas
2021-08-26 12:29 ` David Howells
2022-01-27 14:42 ` Roberto Bergantinos Corpas
2021-08-26 12:46 ` Matthew Wilcox [this message]
2021-08-26 13:05 ` Eric Sandeen
2021-08-26 13:32 ` Roberto Bergantinos Corpas
2021-09-23 12:28 ` David Wysochanski
2021-09-23 14:13 ` Roberto Bergantinos Corpas
2022-09-28 1:09 Ian Kent
2023-01-27 11:13 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YSeNNnNBW7ceLuh+@casper.infradead.org \
--to=willy@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=rbergant@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).