From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0928C433EF for ; Wed, 6 Oct 2021 12:55:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A213061039 for ; Wed, 6 Oct 2021 12:55:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231473AbhJFM4v (ORCPT ); Wed, 6 Oct 2021 08:56:51 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:38941 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231259AbhJFM4v (ORCPT ); Wed, 6 Oct 2021 08:56:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633524899; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7EGx+I3Pcl/Qx0WL2hHgN+pODGh3Si8+GexZplFhi04=; b=YT+AuhgbehXAQVouF3fxT0BbaKO/e+EydaHgCkCcY/49gDzHB35UkHOZvTL9/f4fFvkSF1 Bx2i0XJY/0zNQfFpFFMNSKlOAnJ83z5j135FXZlzLoJ0dV0V+TRhkCJm2TuinyIFxMrTLo oGcQKQ9Om0WS2zeWzlDoPtKSUIMMx+g= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-381-SZmBAHDAOcS23sfjdW1odA-1; Wed, 06 Oct 2021 08:54:57 -0400 X-MC-Unique: SZmBAHDAOcS23sfjdW1odA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C7870107B27C; Wed, 6 Oct 2021 12:54:56 +0000 (UTC) Received: from horse.redhat.com (unknown [10.22.17.87]) by smtp.corp.redhat.com (Postfix) with ESMTP id 98FBD1F42A; Wed, 6 Oct 2021 12:54:56 +0000 (UTC) Received: by horse.redhat.com (Postfix, from userid 10451) id 1FA28220BDB; Wed, 6 Oct 2021 08:54:56 -0400 (EDT) Date: Wed, 6 Oct 2021 08:54:56 -0400 From: Vivek Goyal To: Miklos Szeredi Cc: linux-fsdevel@vger.kernel.org, virtio-fs-list , Stefan Hajnoczi , Ioannis Angelakopoulos , jaggel@bu.edu, "Dr. David Alan Gilbert" Subject: Re: [PATCH 5/8] virtiofs: Add a virtqueue for notifications Message-ID: References: <20210930143850.1188628-1-vgoyal@redhat.com> <20210930143850.1188628-6-vgoyal@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, Oct 06, 2021 at 02:46:46PM +0200, Miklos Szeredi wrote: > On Thu, 30 Sept 2021 at 16:39, Vivek Goyal wrote: > > > @@ -34,10 +35,12 @@ static LIST_HEAD(virtio_fs_instances); > > > > enum { > > VQ_TYPE_HIPRIO, > > - VQ_TYPE_REQUEST > > + VQ_TYPE_REQUEST, > > + VQ_TYPE_NOTIFY > > }; > > > > #define VQ_NAME_LEN 24 > > +#define VQ_NOTIFY_ELEMS 16 /* Number of notification elements */ > > Where does this number come from? I just chose an arbitrary number. Not sure what's a good number and how to decide that. Good thing is that its not part of the protocol so guest should be able to change it if need be. Stefan, do you have any thoughts on this depending on what other virtio drivers have done w.r.t this. Thanks Vivek