From: Matthew Wilcox <willy@infradead.org>
To: David Howells <dhowells@redhat.com>
Cc: Jeff Layton <jlayton@kernel.org>,
Marc Dionne <marc.dionne@auristor.com>,
Ilya Dryomov <idryomov@gmail.com>,
Dominique Martinet <asmadeus@codewreck.org>,
v9fs-developer@lists.sourceforge.net,
linux-afs@lists.infradead.org, ceph-devel@vger.kernel.org,
linux-cachefs@redhat.com, linux-fsdevel@vger.kernel.org,
linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org,
devel@lists.orangefs.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 5/6] netfs, 9p, afs, ceph: Use folios
Date: Wed, 3 Nov 2021 14:21:17 +0000 [thread overview]
Message-ID: <YYKa3bfQZxK5/wDN@casper.infradead.org> (raw)
In-Reply-To: <163584187452.4023316.500389675405550116.stgit@warthog.procyon.org.uk>
On Tue, Nov 02, 2021 at 08:31:14AM +0000, David Howells wrote:
> -static int v9fs_vfs_writepage_locked(struct page *page)
> +static int v9fs_vfs_write_folio_locked(struct folio *folio)
> {
> - struct inode *inode = page->mapping->host;
> + struct inode *inode = folio_inode(folio);
> struct v9fs_inode *v9inode = V9FS_I(inode);
> - loff_t start = page_offset(page);
> + loff_t start = folio_pos(folio);
> loff_t size = i_size_read(inode);
> struct iov_iter from;
> - int err, len;
> + size_t gran = folio_size(folio), len;
> + int err;
>
> - if (page->index == size >> PAGE_SHIFT)
> - len = size & ~PAGE_MASK;
> - else
> - len = PAGE_SIZE;
> + len = (size >= start + gran) ? gran : size - start;
This seems like the most complicated way to write this ... how about:
size_t len = min_t(loff_t, isize - start, folio_size(folio));
> @@ -322,23 +322,24 @@ static void afs_req_issue_op(struct netfs_read_subrequest *subreq)
>
> static int afs_symlink_readpage(struct file *file, struct page *page)
> {
> - struct afs_vnode *vnode = AFS_FS_I(page->mapping->host);
> + struct afs_vnode *vnode = AFS_FS_I(page_mapping(page)->host);
How does swap end up calling readpage on a symlink?
> ret = afs_fetch_data(fsreq->vnode, fsreq);
> - page_endio(page, false, ret);
> + page_endio(&folio->page, false, ret);
We need a folio_endio() ...
> int afs_write_end(struct file *file, struct address_space *mapping,
> loff_t pos, unsigned len, unsigned copied,
> - struct page *page, void *fsdata)
> + struct page *subpage, void *fsdata)
> {
> + struct folio *folio = page_folio(subpage);
> struct afs_vnode *vnode = AFS_FS_I(file_inode(file));
> unsigned long priv;
> - unsigned int f, from = pos & (thp_size(page) - 1);
> + unsigned int f, from = pos & (folio_size(folio) - 1);
Isn't that:
size_t from = offset_in_folio(folio, pos);
(not that i think we're getting folios larger than 4GB any time soon,
but it'd be nice to be prepared for it)
next prev parent reply other threads:[~2021-11-03 14:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-02 8:29 [PATCH v3 0/6] netfs, 9p, afs, ceph: Support folios, at least partially David Howells
2021-11-02 8:29 ` [PATCH v3 1/6] afs: Sort out symlink reading David Howells
2021-11-02 8:29 ` [PATCH v3 2/6] 9p: Convert to using the netfs helper lib to do reads and caching David Howells
2021-11-02 8:30 ` [PATCH v3 3/6] folio: Add a function to change the private data attached to a folio David Howells
2021-11-02 8:30 ` [PATCH v3 4/6] folio: Add a function to get the host inode for " David Howells
2021-11-03 13:16 ` Matthew Wilcox
2021-11-03 14:34 ` David Howells
2021-11-02 8:31 ` [PATCH v3 5/6] netfs, 9p, afs, ceph: Use folios David Howells
2021-11-03 14:21 ` Matthew Wilcox [this message]
2021-11-03 14:58 ` David Howells
2021-11-03 16:27 ` Matthew Wilcox
2021-11-04 14:32 ` David Howells
2021-11-03 16:00 ` [PATCH] folio: Add replacements for page_endio() David Howells
2021-11-02 8:31 ` [PATCH v3 6/6] afs: Use folios in directory handling David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYKa3bfQZxK5/wDN@casper.infradead.org \
--to=willy@infradead.org \
--cc=asmadeus@codewreck.org \
--cc=ceph-devel@vger.kernel.org \
--cc=devel@lists.orangefs.org \
--cc=dhowells@redhat.com \
--cc=idryomov@gmail.com \
--cc=jlayton@kernel.org \
--cc=linux-afs@lists.infradead.org \
--cc=linux-cachefs@redhat.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
--cc=marc.dionne@auristor.com \
--cc=v9fs-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).