From: Al Viro <viro@zeniv.linux.org.uk>
To: Stephen Brennan <stephen.s.brennan@oracle.com>
Cc: linux-kernel@vger.kernel.org,
Luis Chamberlain <mcgrof@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Jan Kara <jack@suse.cz>,
linux-fsdevel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Amir Goldstein <amir73il@gmail.com>
Subject: Re: [PATCH v2 1/4] dcache: sweep cached negative dentries to the end of list of siblings
Date: Wed, 16 Feb 2022 03:27:39 +0000 [thread overview]
Message-ID: <YgxvK03Q3wBVfLYS@zeniv-ca.linux.org.uk> (raw)
In-Reply-To: <875ypf8s5m.fsf@stepbren-lnx.us.oracle.com>
On Tue, Feb 15, 2022 at 06:24:53PM -0800, Stephen Brennan wrote:
> It seems to me that, if we had taken a reference on child by
> incrementing the reference count prior to unlocking it, then
> dentry_unlist could never have been called, since we would never have
> made it into __dentry_kill. child would still be on the list, and any
> cursor (or sweep_negative) list updates would now be reflected in
> child->d_child.next. But dput is definitely not safe while holding a
> lock on a parent dentry (even more so now thanks to my patch), so that
> is out of the question.
>
> Would dput_to_list be an appropriate solution to that issue? We can
> maintain a dispose list in d_walk and then for any dput which really
> drops the refcount to 0, we can handle them after d_walk is done. It
> shouldn't be that many dentries anyway.
Interesting idea, but... what happens to behaviour of e.g.
shrink_dcache_parent()? You'd obviously need to modify the test in
select_collect(), but then the selected dentries become likely candidates
for d_walk() itself wanting to move them over to its internal shrink list.
OTOH, __dput_to_list() will just decrement the count and skip the sucker
if it's already on a shrink list...
It might work, but it really needs a careful analysis wrt.
parallel d_walk(). What happens when you have two threads hitting
shrink_dcache_parent() on two different places, one being an ancestor
of another? That can happen in parallel, and currently it does work
correctly, but that's fairly delicate and there are places where a minor
change could turn O(n) into O(n^2), etc.
Let me think about that - I'm not saying it's hopeless, and it
would be nice to avoid that subtlety in dentry_unlist(), but there
might be dragons.
next prev parent reply other threads:[~2022-02-16 3:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-09 23:14 [PATCH v2 0/4] Fix softlockup when adding inotify watch Stephen Brennan
2022-02-09 23:14 ` [PATCH v2 1/4] dcache: sweep cached negative dentries to the end of list of siblings Stephen Brennan
2022-02-10 5:33 ` Al Viro
2022-02-16 2:24 ` Stephen Brennan
2022-02-16 3:27 ` Al Viro [this message]
2022-02-16 3:49 ` Al Viro
2022-02-16 7:43 ` Stephen Brennan
2022-02-09 23:14 ` [PATCH v2 2/4] fsnotify: stop walking child dentries if remaining tail is negative Stephen Brennan
2022-02-09 23:14 ` [PATCH v2 3/4] dcache: add action D_WALK_SKIP_SIBLINGS to d_walk() Stephen Brennan
2022-02-09 23:14 ` [PATCH v2 4/4] dcache: stop walking siblings if remaining dentries all negative Stephen Brennan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgxvK03Q3wBVfLYS@zeniv-ca.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=amir73il@gmail.com \
--cc=arnd@arndb.de \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=stephen.s.brennan@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).