From: Matthew Wilcox <willy@infradead.org>
To: Colin Walters <walters@verbum.org>
Cc: James Bottomley <James.Bottomley@hansenpartnership.com>,
Dave Chinner <david@fromorbit.com>,
Roman Gushchin <roman.gushchin@linux.dev>,
Stephen Brennan <stephen.s.brennan@oracle.com>,
lsf-pc@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org,
Gautham Ananthakrishna <gautham.ananthakrishna@oracle.com>,
khlebnikov@yandex-team.ru
Subject: Re: [LSF/MM TOPIC] Better handling of negative dentries
Date: Tue, 22 Mar 2022 20:37:21 +0000 [thread overview]
Message-ID: <YjozgfjcNLXIQKhG@casper.infradead.org> (raw)
In-Reply-To: <42d92c6f-28f2-459b-bc2a-13dd655dd4ae@www.fastmail.com>
On Tue, Mar 22, 2022 at 04:17:16PM -0400, Colin Walters wrote:
>
>
> On Tue, Mar 22, 2022, at 3:19 PM, James Bottomley wrote:
> >
> > Well, firstly what is the exact problem? People maliciously looking up
> > nonexistent files
>
> Maybe most people have seen it, but for those who haven't:
> https://bugzilla.redhat.com/show_bug.cgi?id=1571183
> was definitely one of those things that just makes one recoil in horror.
>
> TL;DR NSS used to have code that tried to detect "is this a network filesystem"
> by timing `stat()` calls to nonexistent paths, and this massively boated
> the negative dentry cache and caused all sorts of performance problems.
> It was particularly confusing because this would just happen as a side effect of e.g. executing `curl https://somewebsite`.
>
> That code wasn't *intentionally* malicious but...
Oh, the situation where we encountered the problem was systemd.
Definitely not malicious, and not even stupid (as the NSS example above).
I forget exactly which thing it was, but on some fairly common event
(user login?), it looked up a file in a PATH of some type, failed
to find it in the first two directories, then created it in a third.
At logout, it deleted the file. Now there are three negative dentries.
Repeat a few million times (each time looking for a different file)
with no memory pressure and you have a thoroughly soggy machine that
is faster to reboot than to reclaim dentries.
next prev parent reply other threads:[~2022-03-22 20:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-15 19:55 [LSF/MM TOPIC] Better handling of negative dentries Matthew Wilcox
2022-03-15 20:56 ` Roman Gushchin
2022-03-16 2:07 ` Gao Xiang
2022-03-16 2:52 ` Dave Chinner
2022-03-16 3:08 ` Gao Xiang
2022-03-22 15:08 ` Matthew Wilcox
2022-03-22 19:19 ` James Bottomley
2022-03-22 20:17 ` Colin Walters
2022-03-22 20:27 ` James Bottomley
2022-03-22 20:37 ` Matthew Wilcox [this message]
2022-03-22 21:08 ` Stephen Brennan
2022-03-29 15:24 ` James Bottomley
2022-03-31 19:27 ` Stephen Brennan
2022-04-01 15:45 ` James Bottomley
2022-03-22 22:21 ` Dave Chinner
2022-03-22 20:41 ` Matthew Wilcox
2022-03-22 21:19 ` Roman Gushchin
2022-03-22 22:29 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YjozgfjcNLXIQKhG@casper.infradead.org \
--to=willy@infradead.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=david@fromorbit.com \
--cc=gautham.ananthakrishna@oracle.com \
--cc=khlebnikov@yandex-team.ru \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lsf-pc@lists.linux-foundation.org \
--cc=roman.gushchin@linux.dev \
--cc=stephen.s.brennan@oracle.com \
--cc=walters@verbum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).