From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Jan Kara <jack@suse.cz>
Cc: Ferry Toth <ftoth@exalondelft.nl>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org
Subject: Re: [GIT PULL] ext2, quota, and udf fixes for 6.6-rc1
Date: Thu, 19 Oct 2023 11:46:58 +0300 [thread overview]
Message-ID: <ZTDtAiDRuPcS2Vwd@smile.fi.intel.com> (raw)
In-Reply-To: <20231018184613.tphd3grenbxwgy2v@quack3>
On Wed, Oct 18, 2023 at 08:46:13PM +0200, Jan Kara wrote:
> On Tue 17-10-23 19:02:52, Andy Shevchenko wrote:
> > On Tue, Oct 17, 2023 at 06:34:50PM +0300, Andy Shevchenko wrote:
> > > On Tue, Oct 17, 2023 at 06:14:54PM +0300, Andy Shevchenko wrote:
> > > > On Tue, Oct 17, 2023 at 05:50:10PM +0300, Andy Shevchenko wrote:
> > > > > On Tue, Oct 17, 2023 at 04:42:29PM +0300, Andy Shevchenko wrote:
> > > > > > On Tue, Oct 17, 2023 at 03:32:45PM +0200, Jan Kara wrote:
> > > > > > > On Tue 17-10-23 14:46:20, Andy Shevchenko wrote:
> > > > > > > > On Tue, Oct 17, 2023 at 01:32:53PM +0300, Andy Shevchenko wrote:
> > > > > > > > > On Tue, Oct 17, 2023 at 01:29:27PM +0300, Andy Shevchenko wrote:
> > > > > > > > > > On Tue, Oct 17, 2023 at 01:27:19PM +0300, Andy Shevchenko wrote:
> > > > > > > > > > > On Wed, Aug 30, 2023 at 12:24:34PM +0200, Jan Kara wrote:
> > > > > > > > > > > > Hello Linus,
...
> > > > > > > > > > > This merge commit (?) broke boot on Intel Merrifield.
> > > > > > > > > > > It has earlycon enabled and only what I got is watchdog
> > > > > > > > > > > trigger without a bit of information printed out.
> > > > > > > >
> > > > > > > > Okay, seems false positive as with different configuration it
> > > > > > > > boots. It might be related to the size of the kernel itself.
> > > > > > >
> > > > > > > Ah, ok, that makes some sense.
> > > > > >
> > > > > > I should have mentioned that it boots with the configuration say "A",
> > > > > > while not with "B", where "B" = "A" + "C" and definitely the kernel
> > > > > > and initrd sizes in the "B" case are bigger.
> > > > >
> > > > > If it's a size (which is only grew from 13M->14M), it's weird.
> > > > >
> > > > > Nevertheless, I reverted these in my local tree
> > > > >
> > > > > 85515a7f0ae7 (HEAD -> topic/mrfld) Revert "defconfig: enable DEBUG_SPINLOCK"
> > > > > 786e04262621 Revert "defconfig: enable DEBUG_ATOMIC_SLEEP"
> > > > > 76ad0a0c3f2d Revert "defconfig: enable DEBUG_INFO"
> > > > > f8090166c1be Revert "defconfig: enable DEBUG_LIST && DEBUG_OBJECTS_RCU_HEAD"
> > > > >
> > > > > and it boots again! So, after this merge something affects one of this?
> > > > >
> > > > > I'll continuing debugging which one is a culprit, just want to share
> > > > > the intermediate findings.
> > > >
> > > > CONFIG_DEBUG_LIST with this merge commit somehow triggers this issue.
> > > > Any ideas?
> >
> > > Dropping CONFIG_QUOTA* helps as well.
> >
> > More precisely it's enough to drop either from CONFIG_DEBUG_LIST and CONFIG_QUOTA
> > to make it boot again.
> >
> > And I'm done for today.
>
> OK, thanks for debugging! So can you perhaps enable CONFIG_DEBUG_LIST
> permanently in your kernel config and then bisect through the quota changes
> in the merge? My guess is commit dabc8b20756 ("quota: fix dqput() to follow
> the guarantees dquot_srcu should provide") might be the culprit given your
> testing but I fail to see how given I don't expect any quotas to be used
> during boot of your platform... BTW, there's also fixup: 869b6ea160
> ("quota: Fix slow quotaoff") merged last week so you could try testing a
> kernel after this fix to see whether it changes anything.
It's exactly what my initial report is about, CONFIG_DEBUG_LIST was there
always with CONFIG_QUOTA as well.
Two bisections (v6.5 .. v6.6-rc1 & something...v6.6-rc6) pointed out to
merge commit! I _had_ tried to simply revert the quota changes (I haven't
said about that before) and it didn't help. I'm so puzzled with all this.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-10-19 8:47 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-30 10:24 [GIT PULL] ext2, quota, and udf fixes for 6.6-rc1 Jan Kara
2023-08-30 19:50 ` pr-tracker-bot
2023-10-17 10:27 ` Andy Shevchenko
2023-10-17 10:29 ` Andy Shevchenko
2023-10-17 10:32 ` Andy Shevchenko
2023-10-17 11:36 ` Jan Kara
2023-10-17 11:49 ` Andy Shevchenko
2023-10-17 11:46 ` Andy Shevchenko
2023-10-17 13:32 ` Jan Kara
2023-10-17 13:42 ` Andy Shevchenko
2023-10-17 14:50 ` Andy Shevchenko
2023-10-17 15:14 ` Andy Shevchenko
2023-10-17 15:34 ` Andy Shevchenko
2023-10-17 16:02 ` Andy Shevchenko
2023-10-18 18:46 ` Jan Kara
2023-10-19 8:46 ` Andy Shevchenko [this message]
2023-10-19 10:18 ` Jan Kara
2023-10-19 12:01 ` Andy Shevchenko
2023-10-19 14:12 ` Andy Shevchenko
2023-10-19 14:49 ` Andy Shevchenko
2023-10-19 14:44 ` Andy Shevchenko
2023-10-19 16:42 ` Josh Poimboeuf
2023-10-19 17:05 ` Andy Shevchenko
2023-10-19 17:26 ` Linus Torvalds
2023-10-19 17:51 ` Linus Torvalds
2023-10-19 18:10 ` Andy Shevchenko
2023-10-19 18:16 ` Andy Shevchenko
2023-10-19 18:43 ` Linus Torvalds
2023-10-20 14:51 ` Andy Shevchenko
2023-10-20 15:06 ` Andy Shevchenko
2023-10-20 15:12 ` Andy Shevchenko
2023-10-20 17:26 ` Linus Torvalds
2023-10-20 18:09 ` Jan Kara
2023-10-21 1:48 ` Baokun Li
2023-10-23 12:19 ` Andy Shevchenko
2023-10-23 13:40 ` Baokun Li
2023-10-20 17:23 ` Linus Torvalds
2023-10-20 18:29 ` Andy Shevchenko
2023-10-20 18:31 ` Andy Shevchenko
2023-10-20 19:43 ` Linus Torvalds
2023-10-20 20:36 ` andy.shevchenko
2023-10-21 23:36 ` Kees Cook
2023-10-23 11:45 ` Andy Shevchenko
2023-10-23 12:15 ` Jan Kara
2023-10-23 16:08 ` Kees Cook
2023-10-20 18:05 ` Jan Kara
2023-10-20 20:29 ` andy.shevchenko
2023-10-20 11:07 ` Jan Kara
2023-10-22 13:46 ` Linux regression tracking #adding (Thorsten Leemhuis)
2023-11-22 8:15 ` Linux regression tracking #update (Thorsten Leemhuis)
2023-11-24 16:47 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZTDtAiDRuPcS2Vwd@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=ftoth@exalondelft.nl \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).