linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Omar Sandoval <osandov@osandov.com>
To: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	Alexey Dobriyan <adobriyan@gmail.com>
Cc: Eric Biederman <ebiederm@xmission.com>, kernel-team@fb.com
Subject: [PATCH 1/7] proc/kcore: don't grab lock for kclist_add()
Date: Fri,  6 Jul 2018 12:32:32 -0700	[thread overview]
Message-ID: <a02eecc5a0ab14e5a65407472f827abfc6554e03.1530904769.git.osandov@fb.com> (raw)
In-Reply-To: <cover.1530904769.git.osandov@fb.com>

From: Omar Sandoval <osandov@fb.com>

kclist_add() is only called at init time, so there's no point in
grabbing any locks. We're also going to replace the rwlock with a rwsem,
which we don't want to try grabbing during early boot.

Signed-off-by: Omar Sandoval <osandov@fb.com>
---
 fs/proc/kcore.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/proc/kcore.c b/fs/proc/kcore.c
index e64ecb9f2720..afd1ff8c2d3f 100644
--- a/fs/proc/kcore.c
+++ b/fs/proc/kcore.c
@@ -62,6 +62,7 @@ static LIST_HEAD(kclist_head);
 static DEFINE_RWLOCK(kclist_lock);
 static int kcore_need_update = 1;
 
+/* This doesn't grab kclist_lock, so it should only be used at init time. */
 void
 kclist_add(struct kcore_list *new, void *addr, size_t size, int type)
 {
@@ -69,9 +70,7 @@ kclist_add(struct kcore_list *new, void *addr, size_t size, int type)
 	new->size = size;
 	new->type = type;
 
-	write_lock(&kclist_lock);
 	list_add_tail(&new->list, &kclist_head);
-	write_unlock(&kclist_lock);
 }
 
 static size_t get_kcore_size(int *nphdr, size_t *elf_buflen)
-- 
2.18.0

  reply	other threads:[~2018-07-06 19:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-06 19:32 [PATCH 0/7] /proc/kcore improvements Omar Sandoval
2018-07-06 19:32 ` Omar Sandoval [this message]
2018-07-06 19:32 ` [PATCH 2/7] proc/kcore: replace kclist_lock rwlock with rwsem Omar Sandoval
2018-07-06 19:32 ` [PATCH 3/7] proc/kcore: fix memory hotplug vs multiple opens race Omar Sandoval
2018-07-06 19:32 ` [PATCH 4/7] proc/kcore: hold lock during read Omar Sandoval
2018-07-06 19:32 ` [PATCH 5/7] proc/kcore: clean up ELF header generation Omar Sandoval
2018-07-07 10:05   ` kbuild test robot
2018-07-07 21:28     ` Omar Sandoval
2018-07-06 19:32 ` [PATCH 6/7] proc/kcore: optimize multiple page reads Omar Sandoval
2018-07-06 19:32 ` [PATCH 7/7] proc/kcore: add vmcoreinfo note to /proc/kcore Omar Sandoval

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a02eecc5a0ab14e5a65407472f827abfc6554e03.1530904769.git.osandov@fb.com \
    --to=osandov@osandov.com \
    --cc=adobriyan@gmail.com \
    --cc=ebiederm@xmission.com \
    --cc=kernel-team@fb.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).