From: Jens Axboe <axboe@kernel.dk>
To: Lennert Buytenhek <buytenh@wantstofly.org>, io-uring@vger.kernel.org
Cc: Al Viro <viro@zeniv.linux.org.uk>, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v4 1/2] readdir: split the core of getdents64(2) out into vfs_getdents()
Date: Mon, 29 Mar 2021 14:38:56 -0600 [thread overview]
Message-ID: <a0301cec-2ec3-a3ea-40bd-7d00845705a1@kernel.dk> (raw)
In-Reply-To: <YEuNlKWpQqGMCtL8@wantstofly.org>
On 3/12/21 8:49 AM, Lennert Buytenhek wrote:
> So that IORING_OP_GETDENTS may use it, split out the core of the
> getdents64(2) syscall into a helper function, vfs_getdents().
>
> vfs_getdents() calls into filesystems' ->iterate{,_shared}() which
> expect serialization on struct file, which means that callers of
> vfs_getdents() are responsible for either using fdget_pos() or
> performing the equivalent serialization by hand.
Al, how do you feel about this one?
--
Jens Axboe
prev parent reply other threads:[~2021-03-29 20:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <YEuNMc5LlGftOHW6@wantstofly.org>
2021-03-12 15:49 ` [PATCH v4 1/2] readdir: split the core of getdents64(2) out into vfs_getdents() Lennert Buytenhek
2021-03-29 20:38 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0301cec-2ec3-a3ea-40bd-7d00845705a1@kernel.dk \
--to=axboe@kernel.dk \
--cc=buytenh@wantstofly.org \
--cc=io-uring@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).