From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA7E5C76190 for ; Mon, 15 Jul 2019 08:37:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CAE1121734 for ; Mon, 15 Jul 2019 08:37:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729302AbfGOIhT (ORCPT ); Mon, 15 Jul 2019 04:37:19 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:2227 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729245AbfGOIhT (ORCPT ); Mon, 15 Jul 2019 04:37:19 -0400 Received: from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id DCE869873CB4D6706D46; Mon, 15 Jul 2019 16:37:14 +0800 (CST) Received: from [10.151.23.176] (10.151.23.176) by smtp.huawei.com (10.3.19.213) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 15 Jul 2019 16:37:09 +0800 Subject: Re: [PATCH v2 00/24] erofs: promote erofs from staging To: Pavel Machek , Gao Xiang , "Alexander Viro" CC: , Theodore Ts'o , "Greg Kroah-Hartman" , Miao Xie , , LKML , , Andrew Morton , Linus Torvalds , Chao Yu References: <20190711145755.33908-1-gaoxiang25@huawei.com> <20190714104940.GA1282@xo-6d-61-c0.localdomain> <63b9eaca-5d4b-0fe2-c861-7531977a5b48@aol.com> <20190715075641.GA7695@amd> From: Gao Xiang Message-ID: Date: Mon, 15 Jul 2019 16:37:06 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20190715075641.GA7695@amd> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.151.23.176] X-CFilter-Loop: Reflected Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 2019/7/15 15:56, Pavel Machek wrote: > Hi! > >>>> Changelog from v1: >>>> o resend the whole filesystem into a patchset suggested by Greg; >>>> o code is more cleaner, especially for decompression frontend. >>>> >>>> --8<---------- >>>> >>>> Hi, >>>> >>>> EROFS file system has been in Linux-staging for about a year. >>>> It has been proved to be stable enough to move out of staging >>>> by 10+ millions of HUAWEI Android mobile phones on the market >>>> from EMUI 9.0.1, and it was promoted as one of the key features >>>> of EMUI 9.1 [1], including P30(pro). >>> >>> Ok, maybe it is ready to be moved to kernel proper, but as git can >>> do moves, would it be better to do it as one commit? >>> >>> Separate patches are still better for review, I guess. >> >> Thanks for you reply. Either form is OK for me... The first step could >> be that I hope someone could kindly take some time to look into these >> patches... :) >> >> The patch v2 is slightly different for the current code in the staging >> tree since I did some code cleanup these days (mainly renaming / moving, >> including rename unzip_vle.{c,h} to zdata.{c,h} and some confusing >> structure names and clean up internal.h...). No functional chance and I >> can submit cleanup patches to staging as well if doing moves by git... > > I believe you should get those committed to staging/, yes. Then you > ask Al Viro to do pull the git move, I guess, and you follow his > instructions at that point... > > FILESYSTEMS (VFS and infrastructure) > M: Alexander Viro > L: linux-fsdevel@vger.kernel.org OK, I will send the incremental patches as well later if the above approach can be done in practice... Actually I'd like to get fs people Acked-by about EROFS stuffes, e.g. Al, Ted, etc... Hello? It seems rare filesystems upstreamed these years, but I think EROFS is more useful after moving out of staging. If some people really care about compression ratio, I can add multi-block fixed-output compression support later (Not very hard, it's already on my TODO list), although my current company HUAWEI doesn't have any interest in that way in the near future... In the long term, I'd like to spend my personal free time to decouple code like fscrypt and introduce fscompr for other generic fs to compress unmodified files as well then... That is another stuff. Anyway, EROFS is one of optimal read-only performance solutions for consumer electronics compared with others (Note that block storage has been improved a lot in the past decade...) Thank you very much, Gao Xiang > > Best regards, > Pavel >