From: "André Almeida" <andrealmeid@collabora.com>
To: Gabriel Krisman Bertazi <krisman@collabora.com>
Cc: Hugh Dickins <hughd@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
smcv@collabora.com, kernel@collabora.com, linux-mm@kvack.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Daniel Rosenberg <drosen@google.com>
Subject: Re: [RFC PATCH 2/4] mm: shmem: Support case-insensitive file name lookups
Date: Wed, 24 Mar 2021 17:17:21 -0300 [thread overview]
Message-ID: <a6b6dd15-17ae-13f4-be87-489976e52662@collabora.com> (raw)
In-Reply-To: <877dlxd3oc.fsf@collabora.com>
Às 17:18 de 23/03/21, Gabriel Krisman Bertazi escreveu:
> André Almeida <andrealmeid@collabora.com> writes:
>> opt = fs_parse(fc, shmem_fs_parameters, param, &result);
>> if (opt < 0)
>> @@ -3468,6 +3519,23 @@ static int shmem_parse_one(struct fs_context *fc, struct fs_parameter *param)
>> ctx->full_inums = true;
>> ctx->seen |= SHMEM_SEEN_INUMS;
>> break;
>> + case Opt_casefold:
>> + if (strncmp(param->string, "utf8-", 5))
>> + return invalfc(fc, "Only utf8 encondings are supported");
>> + ret = strscpy(version, param->string + 5, sizeof(version));
>
> Ugh. Now we are doing two strscpy for the parse api (in unicode_load).
> Can change the unicode_load api to reuse it?
>
So instead of getting just the version number (e.g. "12.1.0") as
parameter, utf8_load/unicode_load would get the full encoding string
(e.g. "utf8-12.1.0") right?
next prev parent reply other threads:[~2021-03-24 20:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 19:59 [RFC PATCH 0/4] mm: shmem: Add case-insensitive support for tmpfs André Almeida
2021-03-23 19:59 ` [RFC PATCH 1/4] Revert "libfs: unexport generic_ci_d_compare() and generic_ci_d_hash()" André Almeida
2021-03-23 20:15 ` Matthew Wilcox
2021-03-24 20:09 ` André Almeida
2021-03-23 19:59 ` [RFC PATCH 2/4] mm: shmem: Support case-insensitive file name lookups André Almeida
2021-03-23 20:18 ` Gabriel Krisman Bertazi
2021-03-24 20:17 ` André Almeida [this message]
2021-03-23 23:19 ` Al Viro
2021-03-24 20:44 ` André Almeida
2021-03-23 19:59 ` [RFC PATCH 3/4] mm: shmem: Add IOCTL support for tmpfs André Almeida
2021-03-23 22:15 ` Gabriel Krisman Bertazi
2021-03-23 19:59 ` [RFC PATCH 4/4] docs: tmpfs: Add casefold options André Almeida
2021-03-23 21:58 ` Randy Dunlap
2021-03-25 14:27 ` André Almeida
2021-03-23 22:19 ` Gabriel Krisman Bertazi
2021-03-24 20:47 ` André Almeida
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6b6dd15-17ae-13f4-be87-489976e52662@collabora.com \
--to=andrealmeid@collabora.com \
--cc=akpm@linux-foundation.org \
--cc=drosen@google.com \
--cc=hughd@google.com \
--cc=kernel@collabora.com \
--cc=krisman@collabora.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=smcv@collabora.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).