From: Ian Kent <raven@themaw.net>
To: Christoph Hellwig <hch@lst.de>, Al Viro <viro@zeniv.linux.org.uk>
Cc: David Howells <dhowells@redhat.com>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-security-module@vger.kernel.org,
netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 02/14] autofs: switch to kernel_write
Date: Thu, 14 May 2020 16:25:36 +0800 [thread overview]
Message-ID: <a98e32eb5ad4486fc58e5ce79700a20abecbd69b.camel@themaw.net> (raw)
In-Reply-To: <20200513065656.2110441-3-hch@lst.de>
On Wed, 2020-05-13 at 08:56 +0200, Christoph Hellwig wrote:
> While pipes don't really need sb_writers projection, __kernel_write
> is an
> interface better kept private, and the additional rw_verify_area does
> not
> hurt here.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Right, should be fine AFAICS.
Acked-by: Ian Kent <raven@themaw.net>
> ---
> fs/autofs/waitq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/autofs/waitq.c b/fs/autofs/waitq.c
> index b04c528b19d34..74c886f7c51cb 100644
> --- a/fs/autofs/waitq.c
> +++ b/fs/autofs/waitq.c
> @@ -53,7 +53,7 @@ static int autofs_write(struct autofs_sb_info *sbi,
>
> mutex_lock(&sbi->pipe_mutex);
> while (bytes) {
> - wr = __kernel_write(file, data, bytes, &file->f_pos);
> + wr = kernel_write(file, data, bytes, &file->f_pos);
> if (wr <= 0)
> break;
> data += wr;
next prev parent reply other threads:[~2020-05-14 8:25 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-13 6:56 clean up kernel_{read,write} & friends v2 Christoph Hellwig
2020-05-13 6:56 ` [PATCH 01/14] cachefiles: switch to kernel_write Christoph Hellwig
2020-05-13 6:56 ` [PATCH 02/14] autofs: " Christoph Hellwig
2020-05-14 8:25 ` Ian Kent [this message]
2020-05-13 6:56 ` [PATCH 03/14] bpfilter: " Christoph Hellwig
2020-05-13 6:56 ` [PATCH 04/14] fs: unexport __kernel_write Christoph Hellwig
2020-05-13 6:56 ` [PATCH 05/14] fs: check FMODE_WRITE in __kernel_write Christoph Hellwig
2020-05-13 6:56 ` [PATCH 06/14] fs: remove the call_{read,write}_iter functions Christoph Hellwig
2020-05-13 6:56 ` [PATCH 07/14] fs: implement kernel_write using __kernel_write Christoph Hellwig
2020-05-13 6:56 ` [PATCH 08/14] fs: remove __vfs_write Christoph Hellwig
2020-05-13 6:56 ` [PATCH 09/14] fs: don't change the address limit for ->write_iter in __kernel_write Christoph Hellwig
2020-05-13 6:56 ` [PATCH 10/14] fs: add a __kernel_read helper Christoph Hellwig
2020-05-13 6:56 ` [PATCH 11/14] integrity/ima: switch to using __kernel_read Christoph Hellwig
2020-05-13 6:56 ` [PATCH 12/14] fs: implement kernel_read " Christoph Hellwig
2020-05-13 6:56 ` [PATCH 13/14] fs: remove __vfs_read Christoph Hellwig
2020-05-13 6:56 ` [PATCH 14/14] fs: don't change the address limit for ->read_iter in __kernel_read Christoph Hellwig
2020-05-15 15:21 ` [PATCH 01/14] cachefiles: switch to kernel_write David Howells
[not found] ` <20200516030436.19448-1-hdanton@sina.com>
2020-05-18 6:42 ` [PATCH 09/14] fs: don't change the address limit for ->write_iter in __kernel_write Christoph Hellwig
2020-05-20 15:59 ` clean up kernel_{read,write} & friends v2 Christoph Hellwig
2020-05-28 5:40 Christoph Hellwig
2020-05-28 5:40 ` [PATCH 02/14] autofs: switch to kernel_write Christoph Hellwig
2020-06-24 16:13 clean up kernel_{read,write} & friends v5 Christoph Hellwig
2020-06-24 16:13 ` [PATCH 02/14] autofs: switch to kernel_write Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a98e32eb5ad4486fc58e5ce79700a20abecbd69b.camel@themaw.net \
--to=raven@themaw.net \
--cc=dhowells@redhat.com \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).