From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 245FAC282CF for ; Mon, 28 Jan 2019 16:48:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EABCE2171F for ; Mon, 28 Jan 2019 16:48:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="lg+ZACfR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389161AbfA1Qsn (ORCPT ); Mon, 28 Jan 2019 11:48:43 -0500 Received: from mail-it1-f194.google.com ([209.85.166.194]:50386 "EHLO mail-it1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388961AbfA1Qsn (ORCPT ); Mon, 28 Jan 2019 11:48:43 -0500 Received: by mail-it1-f194.google.com with SMTP id z7so21585072iti.0 for ; Mon, 28 Jan 2019 08:48:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=fEszEDnE9WcL0Eva9wM6KWO3hgFQuwPg6XjOwfEx01E=; b=lg+ZACfR3xtvhH057ReLy8PcgxRrbrXSyCI/7u8KRZtX320ChuEo8inXklTDp6mG66 aQvb5LYOywJnXDTZaD3r2b/vmbuuSo73tdHJSICoRNQenZdoOR703A7CA8jUrCo0zI9Q vwYiz3je5RqcFst4WnDakKFbhXwLSzLExknz05AkHbA3VNq3YbJGkZrvCHYitgRrTxHm 4VDO4v4iOa7kDbNQpsAMYPnxnF1XOmH0kKn4SUA00LNRC9B34AtMW2B/6C+ZCz3Uu290 uMrBD2IjBp3II+jEXmSnLNMjwVTT4qo8mNvw2f5zB/d2HkTMt9p5fEmd+Ok+Z3X3z61E 1pDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=fEszEDnE9WcL0Eva9wM6KWO3hgFQuwPg6XjOwfEx01E=; b=Npj1XjJ5mav4j0/EwQn4H7wKet1wqmdexGNGDe0aLcSxIPzFig/T28GLINllKo8Qsp aXbek73BmYiDTpCWW9zsr5kI3IScxBkPmpDWwb5bu52J1UmeXyunsmS+PT6NuuFUamXs R/O6tlUHWunyNPl8Iz0jZ1xU99Z7Jm93t9zlw5wKH6KH7Y3Rsbv9Ld/3COHQR5Cvl7Ze o3SB76AgoRc3TJiVf3vyy7flg2rJcbW7rCQDyHL1Hdqw0p4Gf4yaSe9k4o/bwBWi8Vna jBIBK2NBw2trJ37fM1HmscuQGRrxsGZoLvYS4YM5OuNvQCxXAmKFnmegI5QmFAXD6fAM +DXA== X-Gm-Message-State: AJcUukcd+JsNXm71MA9kzUue9O6XjIjF6p7ZbOOcRBlr7ime0nNacFq2 /tND9x5w/y8gaEa+zyM/c13FAMfR710= X-Google-Smtp-Source: ALg8bN7tcQ6WZ4MILUHCS7XHLf/Hli2078EJbCkvbmWQjXmu3ecqsgN3ci7NT2tfKpxrEIT+5BWdmg== X-Received: by 2002:a24:4a95:: with SMTP id k143mr10351560itb.77.1548694122102; Mon, 28 Jan 2019 08:48:42 -0800 (PST) Received: from [192.168.1.158] ([216.160.245.98]) by smtp.gmail.com with ESMTPSA id m45sm17227993iti.10.2019.01.28.08.48.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 28 Jan 2019 08:48:41 -0800 (PST) Subject: Re: [PATCH 08/18] fs: add fget_many() and fput_many() To: Christoph Hellwig Cc: linux-fsdevel@vger.kernel.org, linux-aio@kvack.org, linux-block@vger.kernel.org, jmoyer@redhat.com, avi@scylladb.com References: <20190123153536.7081-1-axboe@kernel.dk> <20190123153536.7081-10-axboe@kernel.dk> <20190128142928.GC9563@lst.de> From: Jens Axboe Message-ID: Date: Mon, 28 Jan 2019 09:48:40 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190128142928.GC9563@lst.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 1/28/19 7:29 AM, Christoph Hellwig wrote: >> +struct file *fget_many(unsigned int fd, unsigned int refs) >> +{ >> + return __fget(fd, FMODE_PATH, refs); >> +} >> + >> struct file *fget(unsigned int fd) >> { >> - return __fget(fd, FMODE_PATH); >> + return fget_many(fd, 1); > > I'd still prefer removing the double indirection in this call, but > I know you disagree. Not a big deal, I can kill it. -- Jens Axboe